Date: Sat, 17 Dec 2011 22:00:42 +0000 From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> To: Dimitry Andric <dim@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228650 - head/usr.bin/netstat Message-ID: <AD790F6A-42B2-4744-801F-B72A951D5911@lists.zabbadoz.net> In-Reply-To: <4EED109B.9020104@FreeBSD.org> References: <201112171721.pBHHLloU069166@svn.freebsd.org> <4C98B8D8-99F6-4996-A0FB-C128D9384180@lists.zabbadoz.net> <4EED109B.9020104@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17. Dec 2011, at 21:58 , Dimitry Andric wrote: > On 2011-12-17 22:53, Bjoern A. Zeeb wrote: >> >> On 17. Dec 2011, at 17:21 , Dimitry Andric wrote: >> >>> Author: dim >>> Date: Sat Dec 17 17:21:47 2011 >>> New Revision: 228650 >>> URL: http://svn.freebsd.org/changeset/base/228650 >>> >>> Log: >>> In usr.bin/netstat/atalk.c, work around a clang false positive with >>> printf format warnings and conditional operators. >>> >> >> This does not sound like a good idea. Make clang work. > > It's already being worked on, see: > > http://lists.cs.uiuc.edu/pipermail/cfe-dev/2011-November/018464.html > > and: > > http://llvm.org/bugs/show_bug.cgi?id=11313 > > Meanwhile, this is just a temporary workaround. If you think it is too > disruptive, I can just add NO_WFORMAT to the Makefile instead. I'd prefer we do not start mangling source code for things that are not a problem with the code and just a problem with the warning level. Especially if the change will not be required anymore in the future. A Makefile option we can easily identify and grep for, a cast we just forget. /bz -- Bjoern A. Zeeb You have to have visions! Stop bit received. Insert coin for new address family.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AD790F6A-42B2-4744-801F-B72A951D5911>