Date: Mon, 24 Oct 2005 10:34:25 -0400 From: John Baldwin <jhb@freebsd.org> To: obrien@freebsd.org Cc: Roman Kurakin <rik@freebsd.org>, cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/cp if_cp.c Message-ID: <200510241034.27073.jhb@freebsd.org> In-Reply-To: <20051024072423.GA34909@dragon.NUXI.org> References: <200509271657.j8RGvj2n015326@repoman.freebsd.org> <20051024072423.GA34909@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 24 October 2005 03:24 am, David O'Brien wrote: > On Tue, Sep 27, 2005 at 04:57:45PM +0000, Roman Kurakin wrote: > > rik 2005-09-27 16:57:45 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/cp if_cp.c > > Log: > > Restore if_cp.c 1.27 > > ---------------------------- > > revision 1.27 > > date: 2005/09/19 03:10:16; author: imp; state: Exp; lines: > > +3 -2 Make sure that we call if_free(ifp) after bus_teardown_intr. Since > > we could get an interrupt after we free the ifp, and the interrupt > > handler depended on the ifp being still alive, this could, in theory, > > cause a crash. Eliminate this possibility by moving the if_free to after > > the bus_teardown_intr() call. > > > > In fact, this change do nothing for this driver. It is protected from > > this by cp_destroy variable. This variable also protects driver from > > initiation of any activity from network stack with disabled intr > > handler with this change applied. > > You should not have backed out my commit without discussing it with me > and understanding the reason for the change. > Do it again and I *will* be taking it Core. Looks like he added some function prototypes and moved the cdevsw up. Does i compile now with gcc 4.0? It seems that his changes were a lot simpler and didn't destroy nearly as much CVS history as your changes. It would really be preferable to use simpler solutions rather than destroying version history with really big diffs. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200510241034.27073.jhb>