From owner-cvs-all Sat Jul 28 10:49: 8 2001 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [206.40.252.115]) by hub.freebsd.org (Postfix) with ESMTP id 0BC7A37B403; Sat, 28 Jul 2001 10:49:00 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.3/8.11.1) id f6SHmF795737; Sat, 28 Jul 2001 10:48:15 -0700 (PDT) (envelope-from obrien) Date: Sat, 28 Jul 2001 10:48:14 -0700 From: "David O'Brien" To: Steve Kargl Cc: Kris Kennaway , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/pkg_install/add main.c src/usr.sbin/pkg_install/lib str.c Message-ID: <20010728104814.A11239@dragon.nuxi.com> Reply-To: obrien@FreeBSD.ORG References: <200107280159.f6S1xw810069@freefall.freebsd.org> <20010727204037.A58795@xor.obsecurity.org> <20010727214454.A96927@dragon.nuxi.com> <20010727222312.A3093@troutmask.apl.washington.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010727222312.A3093@troutmask.apl.washington.edu>; from sgk@troutmask.apl.washington.edu on Fri, Jul 27, 2001 at 10:23:12PM -0700 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Jul 27, 2001 at 10:23:12PM -0700, Steve Kargl wrote: > Do you have an axe to grind? No I have no axe to grind. I am improving out code. > Your flourish of (e)malloc commits seems to be a knee-jerk reaction > to the proposed inclusion of emalloc and friends into libutil. Have you looked at the diffs??? When the [ex]malloc issue, came up I sent and looked at the code in issue. Perhaps you don't care about poor coding, but when I see it I like to do something about it. Did you read my explanation in arch@freebsd.org? > And, this commit seems to be a slap in the face of Kris. Why?? I saw inefficient coding done in the name of efficiency. The last time I made such a commit I was asked to justify it. So this time, I justified it in the commit message. Would you prefer I didn't give a shit? > Perhaps, you need a break. Depends. Are the hypersensitive ones (which I guess you are now one of) going to be gone when I get back? Earlier this week I was told I could not back out a commit I made w/o a 3rd party's permission. Now I cannot make commits where I've technically justified them? Perhaps I should go work on something where the developers have a more professional approach. -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message