Date: Tue, 26 Jun 2012 12:52:47 -0700 (PDT) From: Pedro Giffuni <pfg@freebsd.org> To: Fabian Keil <freebsd-listen@fabiankeil.de> Cc: Mark Peek <mp@FreeBSD.org>, freebsd-current@FreeBSD.org Subject: Re: [RFT] llquantize for FreeBSD's dtrace Message-ID: <1340740367.88309.YahooMailClassic@web113504.mail.gq1.yahoo.com> In-Reply-To: <20120626210606.632498e2@fabiankeil.de>
next in thread | previous in thread | raw e-mail | index | archive | help
=0A=0A--- Mar 26/6/12, Fabian Keil <freebsd-listen@fabiankeil.de> ha scritt= o:=0A=0A> Pedro Giffuni <pfg@freebsd.org> wrote:=0A> =0A> > --- Mar 26/6/12= , Mark Peek <mp@FreeBSD.org>=0A> ha scritto:=0A> =0A> > > Try this, change = the assert on line 1429 in file=0A> dt_cc.c=0A> > > from:=0A> > > =0A> > > = assert(!(arg & (UINT16_MAX <<=0A> args[i].shift)));=0A> > > =0A> > > to=0A>= > > =0A> > > assert(!(arg & ((uint64_t)UINT16_MAX <<=0A> > > args[i].shift= )));=0A> > > =0A> > =0A> > This certainly looks correct. Thanks Mark !=0A> = > =0A> > I updated the patch:=0A> > =0A> > http://people.freebsd.org/~pfg/p= atches/patch-dtrace-llquantize=0A> =0A> Thanks a lot. Seems to work for me:= =0A> =0A=0ANice!=0A=0AI don't use Dtrace though ... so I'll ask:=0A=0AAny o= bjections against committing it? :).=0A=0APedro.=0A=0A
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1340740367.88309.YahooMailClassic>