Date: Tue, 06 Mar 2007 16:05:57 +0000 From: Bruce M Simpson <bms@incunabulum.net> To: Julian Elischer <julian@elischer.org> Cc: Yar Tikhiy <yar@comp.chem.msu.su>, Kip Macy <kmacy@FreeBSD.org>, freebsd-net@freebsd.org Subject: Re: [PATCH] Ethernet cleanup; 802.1p input and M_PROMISC Message-ID: <45ED9165.5080406@incunabulum.net> In-Reply-To: <45EC9440.8060508@elischer.org> References: <45E8B964.2090200@incunabulum.net> <20070303215359.GB40430@comp.chem.msu.su> <45EA0756.2000107@incunabulum.net> <20070304070458.GG40430@comp.chem.msu.su> <45EB750A.90105@incunabulum.net> <20070305142411.GC57253@comp.chem.msu.su> <45EC2C37.7020604@incunabulum.net> <45EC9440.8060508@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Julian Elischer wrote: > > When we added netgraph we split both the input and output parts > so that they would provide 'natural' entrypoints for a bridge. > Consider where a bridge wants to put packets. In bms_netdev, bridge_input() is entered directly from ether_input(). It may potentially re-enter, so M_PROMISC is cleared on frames thus handed off to if_bridge(4). Same for ng_ether(4). > > Since the split however other code has made use of those entrypoints > at different > times. I'm not sure at the moment whether other code does so now. According to KScope on -CURRENT, the only other places which call the split ether_demux() are dummynet_send() and ng_ether_rcv_upper(). Regards, BMS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45ED9165.5080406>