From owner-dev-commits-src-all@freebsd.org Mon Feb 15 19:18:18 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 830C1536A55; Mon, 15 Feb 2021 19:18:18 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from vtr.rulingia.com (vtr.rulingia.com [IPv6:2001:19f0:5801:ebe:5400:1ff:fe53:30fd]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "vtr.rulingia.com", Issuer "R3" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfYm96fppz3Dyq; Mon, 15 Feb 2021 19:18:17 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from server.rulingia.com (ppp239-208.static.internode.on.net [59.167.239.208]) by vtr.rulingia.com (8.16.1/8.15.2) with ESMTPS id 11FJI1kj036783 (version=TLSv1.3 cipher=AEAD-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Feb 2021 06:18:07 +1100 (AEDT) (envelope-from peter@rulingia.com) DKIM-Filter: OpenDKIM Filter v2.10.3 vtr.rulingia.com 11FJI1kj036783 X-Bogosity: Ham, spamicity=0.000000 Received: from server.rulingia.com (localhost.rulingia.com [127.0.0.1]) by server.rulingia.com (8.16.1/8.16.1) with ESMTPS id 11FJHuJq033873 (version=TLSv1.3 cipher=AEAD-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 16 Feb 2021 06:17:56 +1100 (AEDT) (envelope-from peter@server.rulingia.com) Received: (from peter@localhost) by server.rulingia.com (8.16.1/8.16.1/Submit) id 11FJHuoo033872; Tue, 16 Feb 2021 06:17:56 +1100 (AEDT) (envelope-from peter) Date: Tue, 16 Feb 2021 06:17:56 +1100 From: Peter Jeremy To: "Simon J. Gerraty" Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: ee10666327b6 - main - Links for bmake and bmake.1 Message-ID: References: <202102150122.11F1Mwq8070473@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="twrE+vEe3Pbt6a+X" Content-Disposition: inline In-Reply-To: <202102150122.11F1Mwq8070473@gitrepo.freebsd.org> X-PGP-Key: http://www.rulingia.com/keys/peter.pgp X-Rspamd-Queue-Id: 4DfYm96fppz3Dyq X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 19:18:18 -0000 --twrE+vEe3Pbt6a+X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2021-Feb-15 01:22:58 +0000, "Simon J. Gerraty" wrote: >The branch main has been updated by sjg: > >URL: https://cgit.FreeBSD.org/src/commit/?id=3Dee10666327b622c2f20a4ac17e7= a5673b04e7c9a > >commit ee10666327b622c2f20a4ac17e7a5673b04e7c9a >Author: Simon J. Gerraty >AuthorDate: 2021-02-15 01:20:10 +0000 >Commit: Simon J. Gerraty >CommitDate: 2021-02-15 01:22:21 +0000 > > Links for bmake and bmake.1 > =20 > Some folk forget that make is bmake, and want the links... This breaks installworld with DESTDIR set: =2E.. install -o root -g wheel -m 444 /usr/src/usr.bin/bmake/tests/variables/t= 0/expected.stdout.1 /mnt/usr/tests/usr.bin/bmake/variables/t0/expected.stdo= ut.1 install -o root -g wheel -m 444 Kyuafile /mnt/usr/tests/usr.bin/bmake/va= riables/t0/Kyuafile install -l h -o root -g wheel -m 555 /mntmake /mntbmake install: link /mntmake -> /mntbmake: No such file or directory *** Error code 71 I suspect you want something like: LINKS=3D ${BINDIR}/make ${BINDIR}/bmake Also, it seems odd that you only want the link if tests are enabled - this would seem likely to create more confusion, rather than less. --=20 Peter Jeremy --twrE+vEe3Pbt6a+X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAmAqyMFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi CzTz+g/+LtEZ8vAieqw9FimgXwoYlqdl+PskdnGvOo3p02iJAz5NttAwpwRPlS36 Hy/RuJY1Ewhv3TxQUwGuynZuqNnCsCO86ICZdeI+YNPFKo5SMDIwiPxo9HRfZIOz c99ZwfhFIutEVKycxG8cQNFCTG9N2ac+Mezn4/fU1yh6f4SH2CyUoxbYMgE/qvhe skvD/vvL5wgWO5WGIp/d/qgdyrk7WtELxOxGJ/U9ZwR2BqY5RYJpN5CbcHqkHLvN RiECPON0GeFIeEIxXiTzan5qrIRZeGNUE7zgfQHGxK5XmmvSdZlI5ZbbQKfEBTJd PBJPDuyDJL+bi/VdVgCKV0sqYl5BD6myNOAonFiB45H2LAIdiANH9+XSpkvcZXil aYDZwClPkc46w/06DVRreXrYru1y0ZNNNHhhO1i/k98G8bZO2EniFuxdMH7Rk072 prdg5wlH9WEmg2YTZeVEE4ePVBcPoJ1c5bU/YQe5OVVu2SzOiLrCddXDH2uBL/0b E/LXt7RfLGThGo8BUkup7zviR9Iutckyo30kBOChH7HU3xuq5xgkUGLWF8jzAQMh 8ebhf0J4OGSQS0TmIdrF6UPp0eh6eP/NnfVOsgmOKYhsqHEYFrOO1qz5zffpBj12 BNwniQ+T6/vQgdLIpZ9LHZgmniGf+J+xLQcXTuoYVt/qMzaEOIo= =ZcRd -----END PGP SIGNATURE----- --twrE+vEe3Pbt6a+X--