Date: Wed, 18 Feb 2004 22:30:44 +0300 From: Andrey Chernov <ache@nagual.pp.ru> To: Ruslan Ermilov <ru@FreeBSD.ORG> Cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/gnu/usr.bin/binutils/gasp Makefile src/gnu/usr.bin/binutils/gdb Makefile src/gnu/usr.bin/cvs/cvs Makefile src/gnu/usr.bin/cvs/lib Makefile src/gnu/usr.bin/cvs/libdiff Makefile src/gnu/usr.bin/diff Makefile src/gnu/usr.bin/grep Makefile Message-ID: <20040218193044.GA26653@nagual.pp.ru> In-Reply-To: <20040218190255.GB1578@ip.net.ua> References: <200402170538.i1H5cjQa010622@repoman.freebsd.org> <20040218190255.GB1578@ip.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--MGYHOYXEY6WxJCY8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 18, 2004 at 09:02:55PM +0200, Ruslan Ermilov wrote: > This is bogus. The correct way would be to fix #include's to > spell ``#include <gnu/regex.h>'', but this will be considered > evil as it will take lot of files off their vendor branches. Yes, and it was the reason of commit to NOT do it, using -I instead. > What was wrong with ${.CURDIR}/.../include/gnu, except > misspelling the number of ".."'s in some cases? The reason is that ${.CURDIR}/.... is for _source_ dir, not for final ${DESTDIR} where includes are installed at the start of 'make world'. There is no regex.h in source dir with that name. To make it works, there must be -I${.CURDIR}/.../gnu/lib/libregex insead, but too many ../=20 are ugly in anycase. > I've been slowly working towards removing all instances of > -I${DESTDIR}/usr/include/... in the src/ makefiles. Before > this commit, there were only a few makefiles with > -I${DESTDIR}/usr/include/rpcsvc, but RPC code is known to be > a nightmare to deal with. I am not sure it will be right, only if ${.CURDIR} is in the same place,=20 where ${DESTDIR} is. --=20 Andrey Chernov | http://ache.pp.ru/ --MGYHOYXEY6WxJCY8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iQCVAwUBQDO9ZOJgpPLZnQjrAQGRYAP+LvKhC3NcJOmcG3+RNqiBGrC3RveV4vsV 81nkCg3EExlC5nRc+yybfVuOaiRZ+l48S5zrJr/HY7M/xhHFJAuzOJGd9yUf+OP+ +Pr1D7BCDsVMy09BcPcofbGR/kv4dBLmGyUSjDJf1RYo/BwitiPvbXzjLzVDBg7i 95iSOJBWJiA= =4kPR -----END PGP SIGNATURE----- --MGYHOYXEY6WxJCY8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040218193044.GA26653>