Date: Mon, 07 Jul 2003 22:03:41 +0200 From: "Philippe Charnier" <charnier@xp11.frmug.org> To: Garance A Drosihn <drosih@rpi.edu> Cc: Philippe Charnier <charnier@FreeBSD.org> Subject: Re: cvs commit: src/usr.sbin/lpr/lpd lpd.c ... Message-ID: <200307072003.h67K3fuu051687@xp11.frmug.org> In-Reply-To: Message from Garance A Drosihn <drosih@rpi.edu> <p05210652bb2f55fc4c53@[128.113.24.47]>
next in thread | previous in thread | raw e-mail | index | archive | help
Salut, Garance A Drosihn <drosih@rpi.edu> wrote: >I'm willing to go with the above for the sources in lpr if it >is reasonable to everyone. It's not quite what I want, but I >probably should do something along these lines. > >Actually, let me take that a step further. How about I change >all the source files to have: > >#include "lpr_cdefs.h" >__FBSDID("$FreeBSD$"); > [...] >(note that I sometimes still compile lpr on an older release >of freebsd, old enough that it does not have __FBSDID in it) > >That's probably a little ugly, but I could use it to get all of >lpr using __FBSDID() so other developers will not feel tempted >to add it "for me". And, all the ugliness is off in the one >lpr_cdefs.h file. The nice thing about this for me is that >I *might* even be able to use the "#ident" directive when >compiling under IRIX, and I'll only have to change one file to >do that. Then we should be tempted to also add a crude hack for those OS that do not have err() family functions, making porting easier. I think that dealing with FBSDID is really the fastest stage of porting BSD userland to other OS. sys/cdefs.h seems to propose STRIP_FBSDID ------ ------ Philippe Charnier charnier@{xp11.frmug.org,free.fr,FreeBSD.org} ``a PC not running FreeBSD is like a venusian with no tentacles'' ------------------------------------------------------------------------
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200307072003.h67K3fuu051687>