From owner-svn-src-all@freebsd.org  Thu Mar  3 12:44:18 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C218F7DC5;
 Thu,  3 Mar 2016 12:44:18 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8D3BD27B;
 Thu,  3 Mar 2016 12:44:18 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from laptop015.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 868F61FE022;
 Thu,  3 Mar 2016 13:44:14 +0100 (CET)
Subject: Re: svn commit: r296320 - in head/sys: kern sys
To: Konstantin Belousov <kostikbel@gmail.com>
References: <201603021846.u22IkHWM010861@repo.freebsd.org>
 <56D82E45.3090205@selasky.org> <20160303124138.GS67250@kib.kiev.ua>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <56D8323B.8070407@selasky.org>
Date: Thu, 3 Mar 2016 13:46:51 +0100
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <20160303124138.GS67250@kib.kiev.ua>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Mar 2016 12:44:18 -0000

On 03/03/16 13:41, Konstantin Belousov wrote:
>> The "td_slpcallout" is not drained anywhere, last time I checked. Does
>> >this change require draining of the td_slpcallout in case the thread
>> >immediately is exited/destroyed?
> callout_stop_safe(CS_MIGRBLOCK) is enough in this case.  td_slpcallout
> is only reset from the sleepq code, and the fragment you cited is enough
> to guarantee that no spurious wakeup of the unrelated time-bound sleep
> happens, because TDF_TIMOFAIL flag cannot be cleared after that.
>
> Struct thread memory is type-stable, so callout subsystem never operates
> on the freed memory from td_slpcallout.
>
>

Thank you.

--HPS