From owner-svn-ports-all@freebsd.org Wed Feb 20 07:21:10 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 73BC814E905C; Wed, 20 Feb 2019 07:21:10 +0000 (UTC) (envelope-from tobik@freebsd.org) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 182686A6CD; Wed, 20 Feb 2019 07:21:10 +0000 (UTC) (envelope-from tobik@freebsd.org) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 2497422FAC; Wed, 20 Feb 2019 02:21:09 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 20 Feb 2019 02:21:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=xyKF4w CWW00exXoiq/RQYRTq1VB+NNqVUsGFN5IjUa0=; b=rI1AScKM6rP6aiWE/4qQCd B0ObjOfSjWnly2cCbgFzS/cK4PD/Eykqd5LDUG+Wc1B9wg1RS7rGrb5u2uAsdxpZ 5Cd+wr1dmv58T8lLg7O1BKNxZm3Zh/YgkUcPsoHBDkhMyajG+bkoafkQ49QjjFNj Obu4bmt9NjLHPnevkj4V8uJQ3uERFs7SCOJEBahIW2keZLM1o3pJnXX9jEsk8kMp aAu4dr4nY0UqhYUnMvK0F8LiKb5kDGCMynhVW9QC60GVlAOznFWZiVtYfERApiA2 oPKbN1ATtxozEmbtsOCEzvRIGSO/7jpT99PHXnK/b2YDkgsbz0MbP2aiFvNbIhXA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrtdehgddutdelucdltddurdegtdelrddttd dmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhht necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujggfsehgtderredtredvnecuhfhrohhmpefvohgs ihgrshcumfhorhhtkhgrmhhpuceothhosghikhesfhhrvggvsghsugdrohhrgheqnecuff homhgrihhnpehfrhgvvggsshgurdhorhhgnecukfhppeefuddrudejrddvhedurdejuden ucfrrghrrghmpehmrghilhhfrhhomhepthhosghikhesfhhrvggvsghsugdrohhrghenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from urd.tobik.me (ip1f11fb47.dynamic.kabel-deutschland.de [31.17.251.71]) by mail.messagingengine.com (Postfix) with ESMTPA id A552DE44DF; Wed, 20 Feb 2019 02:21:07 -0500 (EST) Date: Wed, 20 Feb 2019 08:21:05 +0100 From: Tobias Kortkamp To: Cy Schubert Cc: Cy Schubert , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r493407 - head/graphics/xpdf4 Message-ID: <20190220072105.GA8896@urd.tobik.me> References: <20190220063422.GA18880@urd.tobik.me> <201902200655.x1K6tcMV047571@slippy.cwsent.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2fHTh5uZTiUOsy+g" Content-Disposition: inline In-Reply-To: <201902200655.x1K6tcMV047571@slippy.cwsent.com> User-Agent: Mutt/1.11.2 (2019-01-07) X-Rspamd-Queue-Id: 182686A6CD X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.976,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 07:21:10 -0000 --2fHTh5uZTiUOsy+g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 19, 2019 at 10:55:38PM -0800, Cy Schubert wrote: > In message <20190220063422.GA18880@urd.tobik.me>, Tobias Kortkamp=20 > writes: > >=20 > > > > --OXfL5xGRrasGEqWY > > Content-Type: text/plain; charset=3Dus-ascii > > Content-Disposition: inline > > Content-Transfer-Encoding: quoted-printable > > > > On Wed, Feb 20, 2019 at 06:14:57AM +0000, Cy Schubert wrote: > > > Author: cy > > > Date: Wed Feb 20 06:14:57 2019 > > > New Revision: 493407 > > > URL: https://svnweb.freebsd.org/changeset/ports/493407 > > >=3D20 > > > Log: > > > Remove whitespace in USE_QT, otherwise qmake_build is ignored. > > > =3D20 > > > Reported by: Paul Beard > > >=3D20 > > > Modified: > > > head/graphics/xpdf4/Makefile > > >=3D20 > > > Modified: head/graphics/xpdf4/Makefile > > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3= D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D= =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D= =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > > =3D3D=3D3D=3D3D=3D3D > > > --- head/graphics/xpdf4/Makefile Wed Feb 20 04:50:53 2019 (r49340 > > 6) > > > +++ head/graphics/xpdf4/Makefile Wed Feb 20 06:14:57 2019 (r49340 > > 7) > > > @@ -27,8 +27,7 @@ SUB_FILES=3D3D xpdf-man.conf > > > =3D20 > > > USES=3D3D compiler:c++11-lang cmake localbase:ldflags \ > > > desktop-file-utils qt:5 > > > -USE_QT=3D3D buildtools_build,concurrent,core,gui,network,printsuppo > > rt,\ > > > - qmake_build,svg,widgets > > > +USE_QT=3D3D buildtools_build,concurrent,core,gui,network,printsuppo > > rt,qma=3D > > ke_build,svg,widgets > > > > Next step: Replace the , with spaces to actually add Qt dependencies > > to the port. Check with build-depends-list, run-depends-list, > > stage-qa. Currently the port has no Qt 5 dependencies and it fails > > to build in Poudriere: > > > > =3D3D=3D3D=3D3D> Checking for items in pkg-plist which are not in STAGE= DIR > > Error: Missing: libexec/xpdf/xpdf > > Error: Missing: %%DATADIR%%/man/man1/xpdf.1.gz > > =3D3D=3D3D=3D3D> Error: Plist issues found. >=20 > This must have been wrong all along. I'm not sure how it would have=20 > ever built before. Thanks for fixing it. I can confirm that it builds fine now for me in Poudriere. But let me clarify. It was not broken before, only after today. Previously the port used an options helper like GUI_USE=3D QT=3Dx,y,z which was correct. This translates (see [1]) to =2Eif ${PORT_OPTIONS:MGUI} USE_QT+=3D x y z =2Eendif as it should be. It however does *not* translate to =2Eif ${PORT_OPTIONS:MGUI} USE_QT+=3D x,y,z =2Eendif So the refactoring from earlier (removing the GUI option) was not correct and the problem was only introduced today. [1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/make= file-options.html#options-use --2fHTh5uZTiUOsy+g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAlxs/95fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2FgZAf+K/4ekzOP6xfkrUX5hzuu2jSy5ifQg9EnBoZlg59/jUNv2Eh83cE1Y8Xp Vm3+x7OV6gi23b59Hhnz/PbxtDGQ+dMVRg9lfVZ6AGOBUF2l0yhlinVKhrkScPkt YtJOEl8WB1NJXnG6qvSQGW/rr2P/PH5+BmoatQgQm75wiKgSIdNkx9i/3UXvf7jI Ad/cvMAcxZRbidq6ipbfBXWF525H/GLYTuTSdMYFX3qDRdSDtuLAWPjl/Sm+8+CK j2V3JVgqOLMPW6JxyQwVHmbTpwcG/7mkzoBCUJFA7oj4Z74iWdqgQbFMDInAEQXX tHGDPaSjaQCTPBtRHPHF5Hx7UoZR0w== =h4ca -----END PGP SIGNATURE----- --2fHTh5uZTiUOsy+g--