From owner-svn-src-all@freebsd.org Thu Aug 3 12:45:17 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3A176DB65B4; Thu, 3 Aug 2017 12:45:17 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x231.google.com (mail-pf0-x231.google.com [IPv6:2607:f8b0:400e:c00::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F0C8875F60; Thu, 3 Aug 2017 12:45:16 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x231.google.com with SMTP id d67so5963612pfc.0; Thu, 03 Aug 2017 05:45:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=ZZkInlk8nbjw6Hzm1zXUDrCfN2+xI1v9lRIe0iROnOw=; b=LCJlIhKyvU7LFr9P+GGMbA/kCwnspjqqtIiU+N2CokGxjiqqxHmAHPMzKpLzp8m0A9 GbnTHOfyycILDIHVE/wpvbVyefyAGuLtO42ws32jG9Tzig4yngJbd0nh5Q0IxvZKHp2t I9HbZmyFvCMeAiHHxZ3DnhAvC+LrXpNqRbrKdJJz4/OoDVDeuQi7bjMGgxAoYcxCi3mX CvHAJDcT3yXlxewQcPSOHccuR0trlV3Hij0yqVSRN1izwqd4Ct+ZHHIO5YDtgsjaPjhN lo0gIbCZtFVLdG0V6MjcQVwbgJPYtucbPjhR+RPeiD0X6qxErDLcZpBZLhO6LPRbf2Ed kZTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=ZZkInlk8nbjw6Hzm1zXUDrCfN2+xI1v9lRIe0iROnOw=; b=F0mJar7PKIx3A1+ZUFlu16eFZVkPzoSE437XDrBBofbULRDi5vuP5Rm9he3ukUDTTd eaAiLRoOcJ/WUKKiO58JvlGtZHbZvVqFFmdYBFZJURk4ZBRHoYsM+zboKCBqmPWU0BMx n0YOgn0EvPKi6FvESI7IJJggL3k/PlEcT7dnFZeAgqAsiGxV49I3GXfYmGVK/5TKkhx0 VLJkgeINR87s+009lAuDqzUDcACTMIG2LAeJBgknmfa9aSB6/I2sN2GzNQMmMVXP9Fm6 NtbHp5YaBmsW7Py0DgkMzE/NZqEnByPsaCnv+08pfr3Wsc2NBkGM/y/WS97Ln6YQNH+g FyFQ== X-Gm-Message-State: AIVw113Dj1HT/fenMT59YD5Xz0QmwDxgLXdpxrMpfY7PObawT+UitJUg xrJsKK/7VsTU0g== X-Received: by 10.98.33.9 with SMTP id h9mr1503690pfh.185.1501764316268; Thu, 03 Aug 2017 05:45:16 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id q24sm30356206pgc.61.2017.08.03.05.45.14 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 03 Aug 2017 05:45:15 -0700 (PDT) Subject: Re: svn commit: r321969 - in head/sys/boot: arm/at91/libat91 arm/ixp425/boot2 i386/boot2 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_08D14944-C06A-484C-A555-04B8B077EACF"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: Date: Thu, 3 Aug 2017 05:45:13 -0700 Cc: Ngie Cooper , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <18B68C5B-DFB6-4871-9E56-AFACD0D3CBCE@gmail.com> References: <201708030527.v735R5dg041043@repo.freebsd.org> To: Ed Schouten X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 12:45:17 -0000 --Apple-Mail=_08D14944-C06A-484C-A555-04B8B077EACF Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Aug 3, 2017, at 04:48, Ed Schouten wrote: >=20 > 2017-08-03 7:27 GMT+02:00 Ngie Cooper : >> Modified: head/sys/boot/arm/at91/libat91/printf.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/boot/arm/at91/libat91/printf.c Thu Aug 3 03:45:48 = 2017 (r321968) >> +++ head/sys/boot/arm/at91/libat91/printf.c Thu Aug 3 05:27:05 = 2017 (r321969) >> @@ -20,12 +20,13 @@ >> #include >> #include "lib.h" >>=20 >> -void >> +int >> printf(const char *fmt,...) >> { >> va_list ap; >> const char *hex =3D "0123456789abcdef"; >> char buf[10]; >> + const char *fmt_orig =3D fmt; >> char *s; >> unsigned u; >> int c; >> @@ -66,5 +67,5 @@ printf(const char *fmt,...) >> } >> va_end(ap); >>=20 >> - return; >> + return (int)(fmt - fmt_orig); >> } >=20 > This makes printf() return the number of characters from the format > processed, right? This is different from libc's printf(), which > returns the number of characters printed. Yes. markj identified flaws with my approach that need to be = addressed in another commit (unfortunately I didn=E2=80=99t pay close = enough attention to the details when I implemented the change). Thanks, -Ngie --Apple-Mail=_08D14944-C06A-484C-A555-04B8B077EACF Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJZgxrZAAoJEPWDqSZpMIYVQFMQAIQ0UKMtX8Q6Wkc06aqqb7ky kbm3ofOiuxjJ/BtAzaWF3l9wZptLhc7B+8ZrM4XO4781g9oHVw0Z0oY/ncPv86AA OgnK7ASMgb/8hby2KIMhdADRB8v8ciUhsNoIv8hX5pMjU+FwyPNoLI86JvLwZNS4 Zn5F51HDKRm09Kz0djepBVkQgFcpWnsyHF4V7LRvgX2n/3E/X5qyayxvAa63naPA YF7tO4wV4UuVU3LSKF5yQgNDx98u9dmmxn20IyWAGjSD127Uf302NmZazhQqAd93 wFxBpOgeRVgKcRsBMzYmCaynIncz+xPwHDeAchu9MjVP3I7vh0wmEbpo5Ht7YC1c bH21uy+9OaSc4sYm1oZlRzUcs8owKMdSuKXoXmdOSZWwtlAxE+4gkSxkqUQIIi+O T5WVXENQjWR9FOpVPZZLMjvwb5XbeTdMcV4FtCZRUE/R6WhLkDTr8PJHYFGmDoxC FL13wrz/XtvfC66hqtuvJhKNJwOqhJjJSbeKRnwX2IuXAIUaQHCJkGEBddEfSuZH PimJM4p7XUbStdjyboSeECPnlX4JE+QDbJPaC1M6hLcazvPm5WIS6Roy2ovBBV/2 bIEqgo/PWDrZiOlBDMambe8MRId5bSVzIfQpz6o2IKZ2tyQNOjNzBY8R8+KcDQIM tinvf2OijcLFGh2abbhf =WCIN -----END PGP SIGNATURE----- --Apple-Mail=_08D14944-C06A-484C-A555-04B8B077EACF--