Date: Fri, 13 Feb 2009 15:42:56 GMT From: "Ben C. O. Grimm" <freebsd@bengrimm.net> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/131646: rsnapshot exclude statements not properly documented Message-ID: <200902131542.n1DFguSP070589@www.freebsd.org> Resent-Message-ID: <200902131550.n1DFo048099992@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 131646
>Category: ports
>Synopsis: rsnapshot exclude statements not properly documented
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: doc-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Feb 13 15:50:00 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Ben C. O. Grimm
>Release: 7.1-STABLE
>Organization:
None
>Environment:
FreeBSD hail.bengrimm.net 7.1-STABLE FreeBSD 7.1-STABLE #0: Fri Feb 6 17:12:09 CET 2009 root@hail.bengrimm.net:/usr/obj/usr/src/sys/HAIL i386
>Description:
The sysutils/rsnapshot port's config file (rsnapshot.conf) has include/exclude statements. The statements are applied to every rsnapshot backup, even when included config files have different include/exclude statements, or have no include/exclude statements at all.
For example:
in rsnapshot.conf:
include #
exclude #
include_conf /usr/local/etc/host1_rsnapshot.conf
include_conf /usr/local/etc/host2_rsnapshot.conf
in host1_rsnapshot.conf:
exclude backups*
in host2_rsnapshot.conf:
exclude docs*
Executing rsnapshot -v will produce, FOR BOTH HOSTS:
/usr/local/bin/rsync -a --delete --numeric-ids --relative --delete-excluded \
--exclude=backups* --exclude=docs* [etcetera)
Nothing in the man page suggests that this functionality exists when include/exclude statements are used in several included config files.
I'm aware of the fact that includes/excludes will work correctly when they are passed on the backup line itself, like this:
backup root@example.com:/etc/ example.com/ exclude=mtab,exclude=core
>How-To-Repeat:
>Fix:
I think the man file should make it clear that any include/exclude statements that are not part of a 'backup' line will be used for every single backup in a single rsnapshot run, and will be 'added up' and applied across the board.
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902131542.n1DFguSP070589>