Date: Thu, 18 Jan 2007 09:10:47 +0800 (CST) From: Xin LI <delphij@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: jbacon@mcw.edu Subject: ports/108068: [PATCH] Fix misuse of gzip(1) in sysutils/mcweject Message-ID: <200701180110.l0I1AleV042393@tarsier.delphij.net> Resent-Message-ID: <200701180140.l0I1eK3Z064841@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 108068
>Category: ports
>Synopsis: [PATCH] Fix misuse of gzip(1) in sysutils/mcweject
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Jan 18 01:40:20 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator: Xin LI
>Release: FreeBSD 6.2-RELEASE i386
>Organization:
The FreeBSD Project
>Environment:
System: FreeBSD tarsier.delphij.net 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Fri Jan 12 12:23:27 CST 2007 delphij@tarsier.delphij.net:/usr/obj/usr/src/sys/TARSIER i386
>Description:
In sysutils/mcweject, there is an instance of use of '-best'
option of gzip(1), which should be spelled as '--best'. Because the
ports system already have '-9' in GZIP_CMD macro, the option should
be removed because it is useless.
This would break the port after gzip(1) is replaced by a BSD
licensed one.
>How-To-Repeat:
make install
>Fix:
--- patch-mcweject begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/sysutils/mcweject/Makefile,v
retrieving revision 1.2
diff -u -p -u -r1.2 Makefile
--- Makefile 4 Jan 2006 06:23:41 -0000 1.2
+++ Makefile 18 Jan 2007 01:03:23 -0000
@@ -30,7 +30,7 @@ do-install:
${INSTALL_PROGRAM} ${WRKSRC}/eject ${PREFIX}/sbin
${CHMOD} 4511 ${PREFIX}/sbin/eject
${INSTALL_DATA} ${WRKSRC}/eject.1 ${PREFIX}/man/man1
- ${GZIP_CMD} -best ${PREFIX}/man/man1/eject.1
+ ${GZIP_CMD} ${PREFIX}/man/man1/eject.1
post-install:
@${CAT} ${PKGMESSAGE}
--- patch-mcweject ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200701180110.l0I1AleV042393>