From owner-svn-src-all@FreeBSD.ORG Fri Jan 29 14:07:33 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BEE9A106568B; Fri, 29 Jan 2010 14:07:33 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail05.syd.optusnet.com.au (mail05.syd.optusnet.com.au [211.29.132.186]) by mx1.freebsd.org (Postfix) with ESMTP id 3BA1E8FC18; Fri, 29 Jan 2010 14:07:32 +0000 (UTC) Received: from c122-106-174-165.carlnfd1.nsw.optusnet.com.au (c122-106-174-165.carlnfd1.nsw.optusnet.com.au [122.106.174.165]) by mail05.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id o0TE7TTH021835 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 30 Jan 2010 01:07:30 +1100 Date: Sat, 30 Jan 2010 01:07:29 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Robert Watson In-Reply-To: <201001291032.o0TAW1VZ034590@svn.freebsd.org> Message-ID: <20100130005028.R77143@delplex.bde.org> References: <201001291032.o0TAW1VZ034590@svn.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r203161 - head/lib/libc/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jan 2010 14:07:33 -0000 On Fri, 29 Jan 2010, Robert Watson wrote: > Log: > You must include fcntl.h (in practice) to be able to do anything useful > with shm_open(2), as otherwise the O_ flags are undefined. Only usually, not "in practice". You can usefully call shm_open() with flags obtained from a variable. > MFC after: 3 days > Modified: head/lib/libc/sys/shm_open.2 > ============================================================================== > --- head/lib/libc/sys/shm_open.2 Fri Jan 29 10:20:11 2010 (r203160) > +++ head/lib/libc/sys/shm_open.2 Fri Jan 29 10:32:01 2010 (r203161) > @@ -39,6 +39,7 @@ > .Sh SYNOPSIS > .In sys/types.h > .In sys/mman.h > +.In fcntl.h > .Ft int > .Fn shm_open "const char *path" "int flags" "mode_t mode" > .Ft int This detail belongs in the description, not in the synopsis. This is correctly handled in POSIX. POSIX also correctly specifies the include of -- it wasn't specified for shm_open() even in POSIX.1-1996 though it was specified for some other functions then. Now it isn't specified for any functions. Bruce