Date: Fri, 1 Feb 2013 01:35:52 +0100 From: "Timur I. Bakeyev" <timur@FreeBSD.org> To: Eitan Adler <eadler@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Bryan Drewery <bdrewery@freebsd.org> Subject: Re: svn commit: r311324 - in head: . misc/amanda-server misc/amanda25-server misc/amanda26-server misc/amanda32-server misc/instant-server net-im/kpopup net-im/linpopup net/jags net/lanbrowsing net/pro... Message-ID: <CALdFvJEaFr_3C3yspJeA7SnoJQpfrqRiq8oO_-Aep3UnySHnbQ@mail.gmail.com> In-Reply-To: <CAF6rxgkXjA7u7d=sasC=qBpObvDobH5BQL3eOCEXxFT0RpP6Kw@mail.gmail.com> References: <201301311914.r0VJE8R8091684@svn.freebsd.org> <510ACB0F.9040402@FreeBSD.org> <CAF6rxgkXjA7u7d=sasC=qBpObvDobH5BQL3eOCEXxFT0RpP6Kw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Sorry, forgot to mention that fix, did it almost automatically...
On Fri, Feb 1, 2013 at 12:34 AM, Eitan Adler <eadler@freebsd.org> wrote:
> On 31 January 2013 14:50, Bryan Drewery <bdrewery@freebsd.org> wrote:
> > On 1/31/2013 1:14 PM, Timur I. Bakeyev wrote:
> >> .if defined (WITH_SAMBA)
> >> -SAMBA_PORT?= samba34
> >> +SAMBA_PORT?= samba36
> >> BUILD_DEPENDS+= smbclient:${PORTSDIR}/net/${SAMBA_PORT}
> >> RUN_DEPENDS+= smbclient:${PORTSDIR}/net/${SAMBA_PORT}
> >> -CONFIGURE_ARGS+= --with-smbclient=${PREFIX}/bin/smbclient
> >> +CONFIGURE_ARGS+= --with-smbclient=${LOCALBASE}/bin/smbclient
> >
> > Shouldn't PREFIX be respected and LOCALBASE just the default?
>
> This diff is correct. PREFIX is where samba will be installed to.
> LOCALBASE refers to where things are already installed. In this case
> smbclient is a build and run depend, which means is already installed
> (and therefore in LOCALBASE).
>
> I wish the commit log were more clear.
>
> --
> Eitan Adler
> Source, Ports, Doc committer
> Bugmeister, Ports Security teams
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALdFvJEaFr_3C3yspJeA7SnoJQpfrqRiq8oO_-Aep3UnySHnbQ>