From owner-cvs-all Thu Feb 13 18:32:21 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C9BAE37B401; Thu, 13 Feb 2003 18:32:19 -0800 (PST) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8DA2D43FA3; Thu, 13 Feb 2003 18:32:18 -0800 (PST) (envelope-from marcel@xcllnt.net) Received: from athlon.pn.xcllnt.net (athlon.pn.xcllnt.net [192.168.4.3]) by ns1.xcllnt.net (8.12.6/8.12.6) with ESMTP id h1E2WI1o031145; Thu, 13 Feb 2003 18:32:18 -0800 (PST) (envelope-from marcel@piii.pn.xcllnt.net) Received: from athlon.pn.xcllnt.net (localhost [127.0.0.1]) by athlon.pn.xcllnt.net (8.12.7/8.12.7) with ESMTP id h1E2WIKQ001625; Thu, 13 Feb 2003 18:32:18 -0800 (PST) (envelope-from marcel@athlon.pn.xcllnt.net) Received: (from marcel@localhost) by athlon.pn.xcllnt.net (8.12.7/8.12.7/Submit) id h1E2WIOt001624; Thu, 13 Feb 2003 18:32:18 -0800 (PST) Date: Thu, 13 Feb 2003 18:32:18 -0800 From: Marcel Moolenaar To: Eric Anholt Cc: Peter Wemm , Dag-Erling Smorgrav , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules Makefile Message-ID: <20030214023218.GA1573@athlon.pn.xcllnt.net> References: <20030213223058.769DA2A8C1@canning.wemm.org> <1045185451.11981.17.camel@leguin> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1045185451.11981.17.camel@leguin> User-Agent: Mutt/1.5.3i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Feb 13, 2003 at 06:06:15PM -0800, Eric Anholt wrote: > > Here's a patch to remove the arch-specific drivers from conf/files and > only enable them for the appropriate architectures. As far as > flush_cache on alpha, everyone else (NetBSD, linux) just does a memory > barrier there, and linux has a note that it's probably wrong but they're > not sure. > > http://people.freebsd.org/~anholt/files/agp-alphadiff > > Does this look appropriate? I think so. There's just one nit: agp_flush_cache(). Can we not rename it to cpu_flush_cache() and have some MD header define it appropriately (or if the implementation is non-trivial have it defined in some MD source file)? -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message