Date: Wed, 25 Oct 2006 14:34:25 +0200 From: Jean-Yves Lefort <jylefort@FreeBSD.org> To: Joe Marcus Clarke <marcus@FreeBSD.org> Cc: FreeBSD GNOME Users <gnome@FreeBSD.org> Subject: Re: Patch to add more GEOM support to hal Message-ID: <20061025143425.0a1f6c64.jylefort@FreeBSD.org> In-Reply-To: <1161699824.1029.6.camel@shumai.marcuscom.com> References: <1161699824.1029.6.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Wed__25_Oct_2006_14_34_25_+0200_b/RH2koeBz8G+M_F Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: 7bit On Tue, 24 Oct 2006 10:23:44 -0400 Joe Marcus Clarke <marcus@FreeBSD.org> wrote: > If you currently use a lot of different GEOM classes, and have noticed > some strange hal-related behavior in GNOME when it comes to mounting > disks, or seeing icons for RAID members on the desktop, try the > following patch for sysutils/hal: > > http://www.marcuscom.com/downloads/patch-geom > > This patch removes libdisk usage from hal, and replaces it with pure > GEOM configuration parsing. I'm interested in getting all feedback. > The idea is to fix any GEOM-related volume problems without introducing > anything new. So if something feels worse after this patch, definitely > let me know. - What are these GEOM problems? - Memory leak: fields = g_strsplit(lines[i], " ", 0); - if (g_strv_length(fields) >= 3 && ! strcmp(fields[1], "DISK")) + if (g_strv_length(fields) < 3) + continue; - Don't forget to remove -ldisk from Makefile.am - Why these explicit conversions? + sibling_geom = g_hash_table_lookup(hf_storage_geom_hash, + (gconstpointer) sibling->data); ^^^^^^^^^^^^^^^ + geom_obj->mediasize = (guint64) strtoumax(fields[3], (char **) NULL, 10); ^^^^^^^^^ ^^^^^^^^^ (and so on) -- Jean-Yves Lefort jylefort@FreeBSD.org http://lefort.be.eu.org/ --Signature=_Wed__25_Oct_2006_14_34_25_+0200_b/RH2koeBz8G+M_F Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFP1nXyzD7UaO4AGoRAr5ZAJ9fKta4pjKISliz5kLG4C9a0SkhYwCeO2Gp XUfGEMvgDa+ihlDOFppPc78= =AcJJ -----END PGP SIGNATURE----- --Signature=_Wed__25_Oct_2006_14_34_25_+0200_b/RH2koeBz8G+M_F--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061025143425.0a1f6c64.jylefort>