From owner-freebsd-current Sat Mar 1 16: 9:22 2003 Delivered-To: freebsd-current@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 931) id B0A4037B401; Sat, 1 Mar 2003 16:09:21 -0800 (PST) Date: Sat, 1 Mar 2003 18:09:21 -0600 From: Juli Mallett To: Jens Rehsack Cc: current@FreeBSD.org Subject: Re: PATCH: type errors in src-tree Message-ID: <20030301180920.A53976@FreeBSD.org> References: <3E5EA13E.9020208@liwing.de> <3E60F1CF.2030400@liwing.de> <20030301155546.A39174@FreeBSD.org> <3E612F7F.1090002@liwing.de> <20030301233642.GA64401@pit.databus.com> <3E614A06.5070403@liwing.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <3E614A06.5070403@liwing.de>; from rehsack@liwing.de on Sun, Mar 02, 2003 at 01:02:14AM +0100 Organisation: The FreeBSD Project X-Alternate-Addresses: , , , , X-Towel: Yes X-Negacore: Yes X-Title: Code Maven Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * De: Jens Rehsack [ Data: 2003-03-01 ] [ Subjecte: Re: PATCH: type errors in src-tree ] > Barney Wolff wrote: > > On Sat, Mar 01, 2003 at 11:09:03PM +0100, Jens Rehsack wrote: > > > > Shouldn't we care about u_char vs char? On some machines it matters, > > and on all machines compilers tend to notice and generate warnings. > > > > Just another question: I turned on '-ansi' and got some warning about a > function declaration is not a prototype (all functions are declared in > K&R style). Is it preferred by the FreeBSD-Team having functions in K&R > styles or is the Ansi-Style on, too? ANSI is preferred, but mixing style with functional changes is discouraged. I get the impression your change to width-specified values has a real correlation to what things need to use, and thus it might fix brokenness with systems not ILP32. Thanx, juli. -- Juli Mallett - AIM: BSDFlata -- IRC: juli on EFnet OpenDarwin, Mono, FreeBSD Developer - ircd-hybrid Developer, EFnet addict FreeBSD on MIPS-Anything on FreeBSD - /* XXX Nothing to see here, now. */ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message