Date: Thu, 3 Mar 2016 14:27:11 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Hans Petter Selasky <hps@selasky.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r296320 - in head/sys: kern sys Message-ID: <20160303122711.GR67250@kib.kiev.ua> In-Reply-To: <56D82A15.3050804@selasky.org> References: <201603021846.u22IkHWM010861@repo.freebsd.org> <56D81918.6020403@selasky.org> <20160303112716.GO67250@kib.kiev.ua> <56D821A7.2020105@selasky.org> <20160303115823.GQ67250@kib.kiev.ua> <56D82A15.3050804@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 03, 2016 at 01:12:05PM +0100, Hans Petter Selasky wrote: > On 03/03/16 12:58, Konstantin Belousov wrote: > >> > > >> >Yes, your change is compatible if you compile the code, but not binary > >> >compatible. See the following macros, and how they use _callout_stop_safe(): > > My change is binary compatible. > > > >> > > >> >#define callout_stop(c) _callout_stop_safe(c, 0, NULL) > >> >#define callout_async_drain(c, d) \ > >> > _callout_stop_safe(c, 0, d) > >> > > >> >Because callout_stop(c) is a macro, you've now change the API for > >> >callout_stop() aswell. This is what I think will break binary > >> >compatibility in 10.x. > > How my commit changes anything for either callout_stop(), or for > > callout_async_drain(), or for callout_drain() ? > > > > Hi, > > It looked like you added another argument to _callout_stop_safe(). After > a closer look I see the patch is binary compatible. Right, and CS_DRAIN value was selected so that callout_drain() arguments to _callout_stop_safe() would be same with or without the change. The only case where the issue could exists, is for some code which called _callout_stop_safe() directly, and passed arbitrary (not "1") non-zero value as the second argument to indicate drain. I believe there is no such code, and tend to consider it as bug, if demostrated. be not different with
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160303122711.GR67250>