From owner-freebsd-net@FreeBSD.ORG  Fri Aug 28 18:48:31 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E9F49106566C;
	Fri, 28 Aug 2009 18:48:31 +0000 (UTC)
	(envelope-from Michael.Tuexen@lurchi.franken.de)
Received: from mail-n.franken.de (drew.ipv6.franken.de
	[IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa])
	by mx1.freebsd.org (Postfix) with ESMTP id 7F2A08FC0A;
	Fri, 28 Aug 2009 18:48:31 +0000 (UTC)
Received: from [IPv6:2002:5481:ebd3::224:36ff:feef:67d1] (unknown
	[IPv6:2002:5481:ebd3:0:224:36ff:feef:67d1])
	by mail-n.franken.de (Postfix) with ESMTP id 5D9C91C0C0BC0;
	Fri, 28 Aug 2009 20:48:28 +0200 (CEST)
Message-Id: <38B715CC-9C82-4D8D-97CC-134A9CB01A0C@lurchi.franken.de>
From: =?ISO-8859-1?Q?Michael_T=FCxen?= <Michael.Tuexen@lurchi.franken.de>
To: "Li, Qing" <qing.li@bluecoat.com>
In-Reply-To: <B583FBF374231F4A89607B4D08578A4305277931@bcs-mail03.internal.cacheflow.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v936)
Date: Fri, 28 Aug 2009 20:48:27 +0200
References: <BFC746D7-9E88-43AD-8320-96928633C532@lurchi.franken.de>
	<B583FBF374231F4A89607B4D08578A4305277931@bcs-mail03.internal.cacheflow.com>
X-Mailer: Apple Mail (2.936)
Cc: qingli@freebsd.org, "Bjoern A. Zeeb" <bz@freebsd.org>,
	Randall Stewart <rrs@lakerest.net>, net@freebsd.org
Subject: Re: routing message problem
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Aug 2009 18:48:32 -0000

Hi Qing,

your patch fixes the issue.
Will it find its way into 8.0?
Will it find its way into 7.3?

Best regards
Michael

On Aug 28, 2009, at 7:24 PM, Li, Qing wrote:

>>
>> Dear all,
>>
>> via a bug report from Preethi I figured out that there are no
>> RTM_NEWADDR
>> routing messages generated when an IP address is added to an  
>> interface
>> and there is already an address in the same network configured.
>> This is a problem for the SCTP stack.
>>
>> To reproduce the problem you can
>> sudo ifconfig em0 192.168.1.1
>> sudo ifconfig em0 192.168.1.2 alias
>>
>> and use the attached problem. It will only show the first address
>> being added. This problem applies to FreeBSD 9.0 CURRENT and 7.2
>> RELEASE.
>>
>> Any idea how to fix the problem?
>>
>
>
>  Please try my patch (not the final version) at
>
> 	http://people.freebsd.org/~qingli/patch-8-28-rtmsg.diff
>
>
>  I have tested it and seems to work as expected. You should
>  get the notifications for both address insertion ("alias")
>  and deletion ("-alias").
>
>  Let me know if it's to your satisfaction.
>
>  I found a couple of other issues while looking over the code.
>
>  1. in_scrubprefix() is called unnecessarily in 2 locations
>  2. the loopback host route is not removed for an alias
>
>  On a related note, in.c can use some code cleanup. I think
>  I will do that post 8.0 release.
>
>  Thanks,
>
>  -- Qing
>
>