Date: Thu, 31 May 2012 23:23:42 -0700 From: Eitan Adler <eadler@freebsd.org> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r236377 - head/sys/dev/vxge/vxgehal Message-ID: <CAF6rxg=MWEDPVND8rZKM72P-1Z9GG%2Bqn99qHhbCNRwmFG=3buA@mail.gmail.com> In-Reply-To: <20120601150242.V1226@besplex.bde.org> References: <201206010423.q514NKtf083043@svn.freebsd.org> <20120601150242.V1226@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 31 May 2012 22:13, Bruce Evans <brde@optusnet.com.au> wrote: > This seems to change a style by (excessive parentheses for a normal > equality test) into logic bug (assignment of dtrh instead of compariing > with it). intentional - perhaps my commit message was poorly worded. The comment above says 283 /* 284 * restore a previously allocated dtrh at current offset and update 285 * the available reserve length accordingly. If dtrh is null just 286 * update the reserve length, only 287 */ and gnn confirmed that the patch as committed is correct. -- Eitan Adler Source & Ports committer X11, Bugbusting teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=MWEDPVND8rZKM72P-1Z9GG%2Bqn99qHhbCNRwmFG=3buA>