From owner-freebsd-audit Wed Jul 18 7:44:16 2001 Delivered-To: freebsd-audit@freebsd.org Received: from coffee.q9media.com (coffee.q9media.com [216.94.229.19]) by hub.freebsd.org (Postfix) with ESMTP id 2187437B405 for ; Wed, 18 Jul 2001 07:44:14 -0700 (PDT) (envelope-from mike@coffee.q9media.com) Received: (from mike@localhost) by coffee.q9media.com (8.11.2/8.11.2) id f6IF0pw52839; Wed, 18 Jul 2001 11:00:51 -0400 (EDT) (envelope-from mike) Date: Wed, 18 Jul 2001 11:00:51 -0400 From: Mike Barcroft To: Alexey Zelkin Cc: audit@FreeBSD.org, Dag-Erling Smorgrav Subject: Re: whois(1) changes Message-ID: <20010718110051.A52720@coffee.q9media.com> References: <20010717214524.A51455@coffee.q9media.com> <20010718154425.A65945@phantom.cris.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010718154425.A65945@phantom.cris.net>; from phantom@FreeBSD.org.ua on Wed, Jul 18, 2001 at 03:44:25PM +0300 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Jul 18, 2001 at 03:44:25PM +0300, Alexey Zelkin wrote: > On Tue, Jul 17, 2001 at 09:45:24PM -0400, Mike Barcroft wrote: > > whois.20010717.patch > > > > o Reintegrate part of phantom's patch which adds gethostinfo(). > > o Create a wrapper for asprintf(3) which checks for failure. > > o Tested on i386, alpha. > > [patch skiped] > > 1. isdigit()'s argument should be explicitly casted to 'unsigned char' per > ache's guidelines. Can you explain this in more detail? To my understanding, one only does this when using setlocale(3) and friends. > 2. I think it's time to go thru include files and cleanup it. As far as I can tell, all the current includes are required. Do you see any includes that can safely be removed? Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message