Date: Fri, 15 Jul 2016 02:19:41 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r302324 - head/lib/libc/locale Message-ID: <3a667ad2-f7d1-7720-3929-99c12245733e@FreeBSD.org> In-Reply-To: <201607031500.u63F0Cr8099783@repo.freebsd.org> References: <201607031500.u63F0Cr8099783@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8VKp8BQbf4tFP5btmwxJdRNMnbIePo5V8 Content-Type: multipart/mixed; boundary="72V63sDQJTrPap2BWubo39vqeOPrXWKp0" From: Jung-uk Kim <jkim@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <3a667ad2-f7d1-7720-3929-99c12245733e@FreeBSD.org> Subject: Re: svn commit: r302324 - head/lib/libc/locale References: <201607031500.u63F0Cr8099783@repo.freebsd.org> In-Reply-To: <201607031500.u63F0Cr8099783@repo.freebsd.org> --72V63sDQJTrPap2BWubo39vqeOPrXWKp0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/03/16 11:00 AM, Baptiste Daroussin wrote: > Author: bapt > Date: Sun Jul 3 15:00:12 2016 > New Revision: 302324 > URL: https://svnweb.freebsd.org/changeset/base/302324 >=20 > Log: > Fix a bad test resulting in a segfault with ISO-8859-5 locales > =20 > Reported by: Lauri Tirkkonen from Illumos > Approved by: re@ (gjb) >=20 > Modified: > head/lib/libc/locale/collate.c >=20 > Modified: head/lib/libc/locale/collate.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/lib/libc/locale/collate.c Sun Jul 3 11:45:54 2016 (r302323) > +++ head/lib/libc/locale/collate.c Sun Jul 3 15:00:12 2016 (r302324) > @@ -310,7 +310,7 @@ _collate_lookup(struct xlocale_collate * > if ((sptr =3D *state) !=3D NULL) { > *pri =3D *sptr; > sptr++; > - if ((sptr =3D=3D *state) || (sptr =3D=3D NULL)) > + if ((sptr =3D=3D *state) || (*sptr =3D=3D 0)) > *state =3D NULL; > else > *state =3D sptr; I had a serious regression with ko_KR.UTF-8 locale after this commit. MATE is unusable because mate-panel is busy looping and eating 100% CPU. GNOME 3 does not start at all, i.e., nothing but mouse cursor on black screen. After reverting this commit, everything is back to normal. Please investigate. IMHO, this must be fixed before 11.0-BETA2 build. Thanks, Jung-uk Kim --72V63sDQJTrPap2BWubo39vqeOPrXWKp0-- --8VKp8BQbf4tFP5btmwxJdRNMnbIePo5V8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXiICDAAoJEHyflib82/FGeagH/RdAwND1dtvbvXCGhO6R5aB8 fR5DE7AxSNJSxcKMGRTL8U+d5nxymLziJboZUZxZPp38UvCu1V17r4kJD5ZOtq9D UgNd3VdZ+OOdVl5hGhZugTNpZe6JUrnILVcMpQN13XvqnTi621Q8LpsmHPDojxWA 8lJNUjeHT5hLD7Le+Yq3me/xiNGrIFk5HvijBtUuQzr5eYvjc9Tm/a/afpXoGrdW /MbJ2IMd8UKwSfW+ALWiJqI8H9NJB76dRG0FjF8/mFtI7nCKm9F1uXx5eYk/rMVO tAslCF7ErJGiAUi90ArfoXCJghO71LNYAqlrGyUTg8ENX7yZtYsAVAjNWdgxPR0= =Hksi -----END PGP SIGNATURE----- --8VKp8BQbf4tFP5btmwxJdRNMnbIePo5V8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3a667ad2-f7d1-7720-3929-99c12245733e>