From owner-freebsd-virtualization@FreeBSD.ORG Tue Mar 6 20:29:33 2012 Return-Path: Delivered-To: freebsd-virtualization@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 64515106566C for ; Tue, 6 Mar 2012 20:29:33 +0000 (UTC) (envelope-from monthadar@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 237748FC14 for ; Tue, 6 Mar 2012 20:29:32 +0000 (UTC) Received: by iahk25 with SMTP id k25so10230168iah.13 for ; Tue, 06 Mar 2012 12:29:32 -0800 (PST) Received-SPF: pass (google.com: domain of monthadar@gmail.com designates 10.50.219.170 as permitted sender) client-ip=10.50.219.170; Authentication-Results: mr.google.com; spf=pass (google.com: domain of monthadar@gmail.com designates 10.50.219.170 as permitted sender) smtp.mail=monthadar@gmail.com; dkim=pass header.i=monthadar@gmail.com Received: from mr.google.com ([10.50.219.170]) by 10.50.219.170 with SMTP id pp10mr11762201igc.49.1331065772679 (num_hops = 1); Tue, 06 Mar 2012 12:29:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=T5vs4ItrziEhhjlHADyFdlwmKN47xJPhfQeqXhTeROk=; b=Mwd1FS6GoOMBvMbWWloH4zBJ3oDAbYi7huRv7/p4IcLaEBYtiWit2lFT8noFJebDCH iRvTCxNDVMsb0rnsg6tgKnCqmFTKbN7eJjdUQ0J6ooAyqLnkkyurkzL8vWLq4Q008XOn FbqO98+TkTa2Nq5FX0kfYKG8YMPpNja3Nm9ZNUTPH5STSdmZ0n8jT2WMCSkx4yBwkwSb hle27A0ji2OT3oTyv0/4jJTCIXZ/GXr20w/GG5JvRzNdLA4jBVIfoGe+Ir+kvYvvA5pj 7iJ3GGVPurKHVe44Dip9fJpvb/ozfVE4jThg3Y7CRbHevCRPX8G0E2i8cSuGXwJvdeQP 9kPA== MIME-Version: 1.0 Received: by 10.50.219.170 with SMTP id pp10mr9797648igc.49.1331065772558; Tue, 06 Mar 2012 12:29:32 -0800 (PST) Received: by 10.50.236.67 with HTTP; Tue, 6 Mar 2012 12:29:32 -0800 (PST) In-Reply-To: <201203062122.15426.zec@fer.hr> References: <201203062122.15426.zec@fer.hr> Date: Tue, 6 Mar 2012 21:29:32 +0100 Message-ID: From: Monthadar Al Jaberi To: Marko Zec Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Adrian Chadd , freebsd-virtualization@freebsd.org Subject: Re: VIMAGE + kldload wlan + kldload wtap panic X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2012 20:29:33 -0000 On Tue, Mar 6, 2012 at 9:22 PM, Marko Zec wrote: > On Tuesday 06 March 2012 21:13:00 Monthadar Al Jaberi wrote: >> I am confused so whats the difference between having wlan in kernel >> config or not? Cuase that seems the reason why we panic... linker >> problems? > > Its not impossible. > > Have you tried to do CURVNET_SET(ss->ss_vap->iv_ifp->if_vnet) on entry to > scan_task() as I suggested earlier in this thread? this is the code I added: diff --git a/sys/net80211/ieee80211_scan.c b/sys/net80211/ieee80211_scan.c index 5c1e3d9..bd20653 100644 --- a/sys/net80211/ieee80211_scan.c +++ b/sys/net80211/ieee80211_scan.c @@ -850,6 +850,7 @@ scan_task(void *arg, int pending) int scandone =3D 0; IEEE80211_LOCK(ic); + CURVNET_SET((struct ieee80211_scan_state *) ss->ss_vap->iv_ifp->if_curvnet); if (vap =3D=3D NULL || (ic->ic_flags & IEEE80211_F_SCAN) =3D=3D 0 |= | (SCAN_PRIVATE(ss)->ss_iflags & ISCAN_ABORT)) { /* Cancelled before we started */ @@ -1004,6 +1005,7 @@ scan_task(void *arg, int pending) ss->ss_ops->scan_restart(ss, vap); /* XXX? */ ieee80211_runtask(ic, &SCAN_PRIVATE(ss)->ss_scan_task); IEEE80211_UNLOCK(ic); + CURVNET_RESTORE(); return; } @@ -1043,6 +1045,7 @@ done: SCAN_PRIVATE(ss)->ss_iflags &=3D ~(ISCAN_CANCEL|ISCAN_ABORT); ss->ss_flags &=3D ~(IEEE80211_SCAN_ONCE | IEEE80211_SCAN_PICK1ST); IEEE80211_UNLOCK(ic); + CURVNET_RESTORE(); #undef ISCAN_REP } same panic... > > Cheers, > > Marko > > >> On Tue, Mar 6, 2012 at 9:06 PM, Adrian Chadd wr= ote: >> > Hi, >> > >> > The trouble here is that net80211 has quite a few other contexts that >> > things are called from: >> > >> > * driver taskqueue; >> > * net80211 taskqueue; >> > * driver callouts; >> > * net80211 callouts; >> > * ioctls via net80211. >> > >> > That's in parallel with frame tx/rx and device ioctls. >> > >> > I don't personally have the time to go through net80211 and driver(s) >> > at the moment to figure out what's going on. Since ath(4) does a bunch >> > of frame processing in taskqueue context (and I'm trying to eliminate >> > frame processing in _callout_ context, ew..) things can potentially >> > get a bit hairy. >> > >> > >> > Adrian >> > >> > On 6 March 2012 11:59, Marko Zec wrote: >> >> On Tuesday 06 March 2012 20:49:38 Monthadar Al Jaberi wrote: >> >>> I added VNET_DEBUG and noticed this warning (original scan_task code= ): >> >>> >> >>> CURVNET_SET() recursion in sosend() line 1350, prev in kern_kldload(= ) >> >>> =A0 =A0 0xfffffe0002202c40 -> 0xfffffe0002202c40 >> >>> KDB: stack backtrace: >> >>> db_trace_self_wrapper() at db_trace_self_wrapper+0x2a >> >>> kdb_backtrace() at kdb_backtrace+0x37 >> >>> sosend() at sosend+0xbd >> >>> clnt_vc_call() at clnt_vc_call+0x3e6 >> >>> clnt_reconnect_call() at clnt_reconnect_call+0xf5 >> >>> newnfs_request() at newnfs_request+0x9fb >> >>> nfscl_request() at nfscl_request+0x72 >> >>> nfsrpc_lookup() at nfsrpc_lookup+0x1be >> >>> nfs_lookup() at nfs_lookup+0x297 >> >>> VOP_LOOKUP_APV() at VOP_LOOKUP_APV+0x95 >> >>> lookup() at lookup+0x3b8 >> >>> namei() at namei+0x484 >> >>> vn_open_cred() at vn_open_cred+0x1e2 >> >>> link_elf_load_file() at link_elf_load_file+0xb3 >> >>> linker_load_module() at linker_load_module+0x794 >> >>> kern_kldload() at kern_kldload+0x145 >> >>> sys_kldload() at sys_kldload+0x84 >> >>> amd64_syscall() at amd64_syscall+0x39e >> >>> Xfast_syscall() at Xfast_syscall+0xf7 >> >> >> >> You can safely ignore those. =A0Recursing on curvnet is harmless, but= in >> >> certain cases can't be avoided. >> >> >> >> When injecting new CURVNET_SET() / CURVNET_RESTORE() points in the >> >> existing code, those warnings are here to help us becoming aware that= we >> >> are setting curvnet in a function which was invoked with an already >> >> valid curvnet context. >> >> >> >> Marko > > --=20 Monthadar Al Jaberi