From owner-svn-src-all@freebsd.org Thu Apr 27 22:06:38 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EC957D53114; Thu, 27 Apr 2017 22:06:38 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qt0-x22b.google.com (mail-qt0-x22b.google.com [IPv6:2607:f8b0:400d:c0d::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A75A51A53; Thu, 27 Apr 2017 22:06:38 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-qt0-x22b.google.com with SMTP id m36so37668135qtb.0; Thu, 27 Apr 2017 15:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=TWpdiqERwKHvFJ9XHMXwljpt520lWaE7RKfiLvZ7NeY=; b=cRsMas35dubBerY6tp/lXh1xEALL+4sG8pVtMk7R05zJ5fLUm6XGCC0tXTTF+HtxY5 g9r7d/nzeGm8J3wNrXliklSopubpQwgTImCY1uHhYuGOWqNwP8Abj3YXxS0Ljb0WTURr hGXnZL6uOiFFVYqXs56/zViFjKkMm+03Y/7l8xLJT3BK/YY42ob70sOv1gQ6MCE9UIX7 9A5HXzzaTkwebjl3feBC00pToGul6NN+EpdRgsHHmhE7JFSGvrivfTyPu1es6tZqbFTW 4j2JlQXbO9dcH9ekxtOnxdn2Cu1yqrQBrSlJ7oRcFbPf05GeSwbBJnEkQkXoo30UWvJl n+jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=TWpdiqERwKHvFJ9XHMXwljpt520lWaE7RKfiLvZ7NeY=; b=V9mQoDo1VMQqKsxigREU+F5ezNctYJVM7p36O/zU8QimP6bDwxeZwYk1+ILK4fJJX0 7sFHQpyHkdFVg4RXUO0TqXhAUsr8gU1CFajr4C+K88IIITwvDHVkPQiXgvNnwZEaJSCw lDsahqPrO7TSQhpRy1FpfJqAQG6nN4Yuk7KdfBbiLPdYrOIQhhRrEeEqSKVsMLigryp0 ChZ4NfDPDLP/OkXEQFYTz0ftZyn2PyZwY07lGK4xIKAPvGD9bfYRqiyT69o+uKjlZmqy E1otJ9jX36cN2UB5DVc5tg8cVrxnykPwrCH9WLf1FW6PIAPyYXl7V7TKUjUEgLgibpmd Y1nw== X-Gm-Message-State: AN3rC/6YyM7r8LvstbBfoTlW8JUJUX+Co9XhCVDa9ChjNeAyJ4BTYQo6 qInsI8cHOQU+bYSjDL082hB7ZMp0IEDP X-Received: by 10.200.50.48 with SMTP id x45mr7566714qta.246.1493330797626; Thu, 27 Apr 2017 15:06:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.93.83 with HTTP; Thu, 27 Apr 2017 15:06:37 -0700 (PDT) In-Reply-To: References: <201703152120.v2FLKHUs052999@repo.freebsd.org> From: Ngie Cooper Date: Thu, 27 Apr 2017 15:06:37 -0700 Message-ID: Subject: Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv To: Ed Maste Cc: Eric Joyner , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-stable@freebsd.org" , "svn-src-stable-10@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Apr 2017 22:06:39 -0000 On Thu, Apr 27, 2017 at 1:07 PM, Ed Maste wrote: > On 15 March 2017 at 17:20, Eric Joyner wrote: >> Author: erj >> Date: Wed Mar 15 21:20:17 2017 >> New Revision: 315333 >> URL: https://svnweb.freebsd.org/changeset/base/315333 >> >> Log: >> ixgbe(4): Update to 3.2.11-k > > This broke tinderbox on many architectures: > > ia64 GENERIC and powerpc GENERIC64: > > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:39: warning: no > previous prototype for 'ixv_read_pci_cfg' [-Wmissing-prototypes] > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:45: warning: no > previous prototype for 'ixv_write_pci_cfg' [-Wmissing-prototypes] > > sparc64 LINT: > > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ix_txrx.c:43: warning: > redundant redeclaration of 'ix_crcstrip' [-Wredundant-decls] > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.h:45: warning: > previous declaration of 'ix_crcstrip' was here > > amd64 LINT: > > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_netmap.c:(.text+0x0): > multiple definition of `ixgbe_netmap_attach' > ixgbe_netmap.o:/scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.c:(.text+0x0): > first defined here Hi Ed, It has to do with netmap(4) refactoring on head not being backported, in combination with ixgbe/ix being MFCed in a refactored state back to ^/stable/10 (it wasn't easy to backport due to PCI-IOV only being on ^/stable/10 -- I tried starting this work and failed because I lacked the hardware to test this out with). This has been known to be broken for almost two months -- a surgical fix should probably be applied to do what's required to make the symbol appear in the appropriate places, since this basically was a direct commit to ^/stable/10 in some regards. Thanks, -Ngie