From owner-cvs-all@FreeBSD.ORG Thu Sep 28 18:44:38 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 23E0616A522; Thu, 28 Sep 2006 18:44:38 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id E149943D69; Thu, 28 Sep 2006 18:44:34 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k8SIiQTk006889; Thu, 28 Sep 2006 14:44:32 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Ruslan Ermilov Date: Thu, 28 Sep 2006 14:20:53 -0400 User-Agent: KMail/1.9.1 References: <200609271957.k8RJv25Z028902@repoman.freebsd.org> <200609281056.28105.jhb@freebsd.org> <20060928162143.GA59634@rambler-co.ru> In-Reply-To: <20060928162143.GA59634@rambler-co.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200609281420.54038.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 28 Sep 2006 14:44:33 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/1950/Thu Sep 28 10:11:54 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/atkbdc atkbd.c src/sys/dev/digi digi.c src/sys/dev/kbdmux kbdmux.c src/sys/dev/syscons scvidctl.c syscons.c src/sys/dev/uart uart_kbd_sun.c src/sys/dev/usb ukbd.c src/sys/dev/vkbd vkbd.c src/sys/fs/procfs procfs_ioctl.c ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2006 18:44:38 -0000 On Thursday 28 September 2006 12:21, Ruslan Ermilov wrote: > > Are there any others outside of SES? How many? If it's a small list, then > > let's fix them. The SES ones are broken as an API anyway as mentioned above, > > and if other ioctl's are copying out a variable amount of data w/o allowing > > for buffer lengths or telling userland how much it copied, they are also > > fundamentally broken as well. > > > Some only read from userland, so they aren't broken. I'll compile and send > you the list of such ioctls (don't have it saved)... Ah, here's one from > memory that isn't broken: SPKRTUNE from sys/dev/speaker/. Scott pointed out one in aac(4) that is required for a binary-only management tool, so it looks like we are stuck _IO being used with pointers. :( -- John Baldwin