Date: Tue, 19 Sep 2006 12:49:11 +0400 From: Roman Bogorodskiy <novel@FreeBSD.org> To: "Andrey V. Elsukov" <bu7cher@yandex.ru> Cc: freebsd-ipfw@FreeBSD.org Subject: Re: A bit weird code Message-ID: <20060919084207.GD93854@novel.fannet.ru> In-Reply-To: <450F6F6D.6020105@yandex.ru> References: <20060918125848.GB93854@novel.fannet.ru> <450F6F6D.6020105@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--84ND8YJRMFlzkrP4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Andrey V. Elsukov wrote: > Roman Bogorodskiy wrote: > >I was reading ipfw sources and spotted such line (sbin/ipfw/ipfw2.c, > >line 4871): > > > >err(EX_UNAVAILABLE, "getsockopt(%s)", "IP_FW_ADD"); > > > >And it's there since 1.1 revision of this file. I wonder it has some > >sacred meaning or just a typo. >=20 > I don't see this code at this line :) > If you mean this code: > if (do_cmd(IP_FW_ADD, rule, (uintptr_t)&i) =3D=3D -1) > err(EX_UNAVAILABLE, "getsockopt(%s)", "IP_FW_ADD"); >=20 > I think this is "copy&paste" bug :) Yeah, my fault, it's actually on line 4829, rev. 1.98. --84ND8YJRMFlzkrP4 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iQCVAwUBRQ+vB4B0WzgdqspGAQKg/gP/T6ZHHVUKeXfMWPxSbAIMs92rq5AXgDSU aHhaseKQmdNG5NVZI2dqNz+odw8g7lRdq83Wr93ZyLYbZ78QYt4tfWnqLRfhoi+E QkGHcvvIehFm6oYqtpyqxiKXVnnhaB8nPgj/AMeFiy2CozwdlRlw6gawkOzOsfGr Hd9RXmvpJqQ= =AQ0J -----END PGP SIGNATURE----- --84ND8YJRMFlzkrP4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060919084207.GD93854>