Date: Sat, 5 Jan 2013 16:09:43 GMT From: pawel@FreeBSD.org To: daniel@morante.net, pawel@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/172595: New port: net-p2p/pushpoold bitcoin push-mining pool server Message-ID: <201301051609.r05G9hvk080325@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
Synopsis: New port: net-p2p/pushpoold bitcoin push-mining pool server
State-Changed-From-To: open->feedback
State-Changed-By: pawel
State-Changed-When: Sat Jan 5 15:55:40 UTC 2013
State-Changed-Why:
Thank you for your submission, during test I have found some things that
need to be addressed:
1) On my system some dependencies are not recorded in Makefile:
[corn:ports/net-p2p/pushpoold]# pkg-lib-check pushpoold ERR: not
registered missing dependency databases/sqlite3 ERR: not registered
missing dependency devel/argp-standalone WARN: not registered implicit
dependency devel/libexecinfo
2) I think that pushpool.conf.sample should be unconditionally
installed in ${PREFIX}/etc/ and if user edition is not required
copied to ${PREFIX}/etc/pushpool.conf - this is how most ports
behave. Technicalities are described here:
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/plist-config.html
3) files/blkmon.conf.sample and files/example-blkmon.cfg files are
almost copies of files in ${WRKSRC}. I think better idea is to modify
(by REINPLACE_CMD? ) files from distfile and then install them -
keeping them in files seems wasteful.
http://www.freebsd.org/cgi/query-pr.cgi?pr=172595
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201301051609.r05G9hvk080325>