Date: Sat, 2 Feb 2008 23:11:53 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Alexander Motin <mav@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Louis Mamakos <louie@transsys.com>, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netgraph/netflow ng_netflow.c Message-ID: <20080202201153.GL14339@FreeBSD.org> In-Reply-To: <200801271501.m0RF1Hki089075@repoman.freebsd.org> References: <200801271501.m0RF1Hki089075@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexander, you should have asked me for review before committing! This is not a bug, this is a feature. This was quite clear from the comments, that you removed: - /* if export hook disconnected stop running expire(). */ This is intended behavior. We must not lose information unless user explicitly wants to lose information. In the latter case he will connect ng_hole(4) node to the "export" hook. But we must not lose information if user runs some script that swaps receiving node on the "export" hook. Please backout this change! I'm sorry that have seen it only after it hit RELENG_6 and RELENG_7 :( But that's your fault that you haven't asked me for review. P.S. I'm closing the PR. On Sun, Jan 27, 2008 at 03:01:16PM +0000, Alexander Motin wrote: A> mav 2008-01-27 15:01:16 UTC A> A> FreeBSD src repository A> A> Modified files: A> sys/netgraph/netflow ng_netflow.c A> Log: A> Run expire even without export hook connected. A> A> PR: kern/119839 A> A> Revision Changes Path A> 1.15 +4 -8 src/sys/netgraph/netflow/ng_netflow.c A> _______________________________________________ A> cvs-all@freebsd.org mailing list A> http://lists.freebsd.org/mailman/listinfo/cvs-all A> To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080202201153.GL14339>