From owner-freebsd-ports@FreeBSD.ORG Sun Oct 7 04:58:48 2007 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B8C6F16A418 for ; Sun, 7 Oct 2007 04:58:48 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with SMTP id 7523F13C448 for ; Sun, 7 Oct 2007 04:58:48 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 26171 invoked by uid 399); 7 Oct 2007 04:58:47 -0000 Received: from localhost (HELO slave.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTP; 7 Oct 2007 04:58:47 -0000 X-Originating-IP: 127.0.0.1 Date: Sat, 6 Oct 2007 21:58:44 -0700 (PDT) From: Doug Barton To: Lars Stokholm In-Reply-To: Message-ID: References: <790a9fff0710051337j710e5f97w809ce08998884648@mail.gmail.com> X-message-flag: Outlook -- Not just for spreading viruses anymore! X-OpenPGP-Key-ID: 0xD5B2F0FB Organization: http://www.FreeBSD.org/ MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-514596749-1191733126=:62920" Cc: Scot Hetzel , freebsd-ports@freebsd.org Subject: Re: Has portmaster gone insane? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2007 04:58:48 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-514596749-1191733126=:62920 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed On Fri, 5 Oct 2007, Lars Stokholm wrote: > On 10/5/07, Scot Hetzel wrote: >> On 10/5/07, Lars Stokholm wrote: >>> Running 'portmaster --clean-distfiles-all' it began to delete *a lot* >>> of files it shouldn't. I haven't had time to see how much is missing, >>> but I guess is so much, that the entire installation is screwed. I'm sincerely sorry that you've had this problem. I think Scot is right in that the code for --clean-distfiles* is pretty simple, and relies totally on a proper definition of DISTDIR. I think I can see _what_ is happening, although I can't tell you why it's happening. Somehow the definition of DISTDIR on your system is empty, and so it's starting the find in / instead of /usr/ports/distfiles as it should. I'll add a check for empty DISTDIR and roll it into an update I'm working on at the moment. >>> It choked on a filename of a weird charset, so it didn't get a chance >>> to delete everything. I'm not sure I understand what you mean here, but I'm glad to hear that it didn't delete everything. Can you please try the attached patch and tell me if you get the error? >> Portmaster uses the following to determine the value of DISTDIR. What >> does this show that DISTDIR is set to? >> >> make BEFOREPORTMK=yes -f/usr/share/mk/bsd.port.mk -V DISTDIR > > I'll have a look tomorrow. I'm very interested in the results here. Doug -- This .signature sanitized for your protection --0-514596749-1191733126=:62920 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=pm-empty-distdir.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=pm-empty-distdir.patch SW5kZXg6IHBvcnRtYXN0ZXIuc2guaW4NCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0NClJDUyBmaWxlOiAvdXNyL2xvY2FsL25jdnMvcG9ydHMvcG9ydHMtbWdt dC9wb3J0bWFzdGVyL2ZpbGVzL3BvcnRtYXN0ZXIuc2guaW4sdg0KcmV0cmll dmluZyByZXZpc2lvbiAxLjIxDQpkaWZmIC11IC1yMS4yMSBwb3J0bWFzdGVy LnNoLmluDQotLS0gcG9ydG1hc3Rlci5zaC5pbgkyIE9jdCAyMDA3IDA0OjQ5 OjQ2IC0wMDAwCTEuMjENCisrKyBwb3J0bWFzdGVyLnNoLmluCTcgT2N0IDIw MDcgMDQ6NTU6NTIgLTAwMDANCkBAIC05MjIsNiArOTIyLDcgQEANCiBmaQ0K IGlmIFsgLXogIiRkaXN0ZGlyIiBdOyB0aGVuDQogCWRpc3RkaXI9YG1ha2Ug QkVGT1JFUE9SVE1LPXllcyAtZi91c3Ivc2hhcmUvbWsvYnNkLnBvcnQubWsg LVYgRElTVERJUmANCisJWyAtbiAiJGRpc3RkaXIiIF0gfHwgZmFpbCAnRVJS T1I6IFRoZSB2YWx1ZSBvZiBESVNURElSIGNhbm5vdCBiZSBudWxsJw0KIAkj IEluIGNhc2UgaXQgaXMgYSBzeW1saW5rDQogCWRpc3RkaXI9IiR7ZGlzdGRp cn0vIg0KIAlleHBvcnQgZGlzdGRpcg0K --0-514596749-1191733126=:62920--