From owner-freebsd-drivers@FreeBSD.ORG Tue Nov 24 04:30:03 2009 Return-Path: Delivered-To: freebsd-drivers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C2881106566C; Tue, 24 Nov 2009 04:30:03 +0000 (UTC) (envelope-from obrien654j@gmail.com) Received: from mail-gx0-f220.google.com (mail-gx0-f220.google.com [209.85.217.220]) by mx1.freebsd.org (Postfix) with ESMTP id 663F78FC0A; Tue, 24 Nov 2009 04:30:03 +0000 (UTC) Received: by gxk20 with SMTP id 20so892192gxk.14 for ; Mon, 23 Nov 2009 20:30:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=WA17Lj3zQUqpFTxR7VdDQrnEhWMYjOjeTNeaGAd30RE=; b=lD0hLgKjP9EfLQvrnbTNEyHyfobmV0wsGDGA16jhFPNP3HEm76aiQ8+CJHeND8nJsS YvxcB3UgpfARwfwNpigkbt48VEhgFbUBwRqSXsxmjL1hzY/BZaJsN3FnOD7aRZpNWza0 jer94bjQWWP+UvgG5Z9VUCYQFR8l3lkuoS3Rw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=cTl0y+b/aZt+lC0wgA2IVf+vW02WCSi9oYWk1kbyBRhXCUEDJ9l2ilaRWqqaJkUjkj QuapIb5AcNteBzX3WHx2RT0IkeKvh9/rI7w24LZ9IKp0+HGvMfOpXC6HRdmVr9m288GX 3j8F4r7+jYb6fAd8lpZu+lrHWiMn6bDjulLh0= Received: by 10.150.29.25 with SMTP id c25mr10133046ybc.245.1259037002830; Mon, 23 Nov 2009 20:30:02 -0800 (PST) Received: from goldengraham ([74.83.26.11]) by mx.google.com with ESMTPS id 5sm1731847ywd.8.2009.11.23.20.30.00 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 23 Nov 2009 20:30:01 -0800 (PST) Date: Mon, 23 Nov 2009 23:30:15 -0500 From: Jeremy O'Brien To: John Baldwin Message-ID: <20091124043015.GA21209@goldengraham> References: <20091122175555.GA15539@minifree.wright.edu> <200911231001.51082.jhb@freebsd.org> <20091123211734.GA1207@minifree> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091123211734.GA1207@minifree> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: freebsd-drivers@freebsd.org Subject: Re: Cisco Aironet MPI350 Fix X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2009 04:30:03 -0000 On Mon, Nov 23, 2009 at 04:17:34PM -0500, Jeremy O'Brien wrote: > On Mon, Nov 23, 2009 at 10:01:50AM -0500, John Baldwin wrote: > > On Sunday 22 November 2009 12:55:55 pm Jeremy O'Brien wrote: > > > Hello, > > > > > > I have a Cisco Aironet MPI350 PCI card in my Thinkpad X31, and on a > > > fresh install of FreeBSD 8.0-RC3, the card did not work. Also, it caused > > > my system to freeze up for a few seconds about once a minute as the > > > driver spit out "an0: device timeout" messages so long as the interface > > > was up. I researched the issue, and found the following fix already in > > > dragonflybsd's tree: > > > > > > > > http://gitweb.dragonflybsd.org/dragonfly.git/commit/7a2a04db44efafea257db883ae3eb5e4ebf2ece9 > > > > > > I modified the patch and applied it to FreeBSD's kernel (trivial), and > > > am happy to report that my card is now working flawlessly. Could someone > > > possibly review this patch and integrate it into the source tree so that > > > others may benefit from it as well? > > > > > > The patch is based off of 8.0-RC3's code, but applies to the latest code > > > as well without modification. > > > > Can you try this version? The IFF_DRV_OACTIVE bits don't look correct to me > > so I've left them out. I also changed the driver to use bus_*() vs > > bus_space_*(). > > > > -- > > John Baldwin > > Tried it at home, worked great. My university's wireless is shoddy. I'm not sure if this is related to your patch or not, but I've been getting spurts of kernel: stray irq7 messages that I don't recall getting before the patch. Do you think it could be related?