From owner-svn-src-all@FreeBSD.ORG Tue Jan 20 11:53:05 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2B87D1065672; Tue, 20 Jan 2009 11:53:05 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from vlakno.cz (77-93-215-190.static.masterinter.net [77.93.215.190]) by mx1.freebsd.org (Postfix) with ESMTP id D69618FC1C; Tue, 20 Jan 2009 11:53:04 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from localhost (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 4D2EA9CB074; Tue, 20 Jan 2009 12:52:36 +0100 (CET) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by localhost (lev.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZgTPl2q0Wqtr; Tue, 20 Jan 2009 12:52:34 +0100 (CET) Received: from vlk.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id F21379CB094; Tue, 20 Jan 2009 12:52:33 +0100 (CET) Received: (from rdivacky@localhost) by vlk.vlakno.cz (8.14.2/8.14.2/Submit) id n0KBqXY1044896; Tue, 20 Jan 2009 12:52:33 +0100 (CET) (envelope-from rdivacky) Date: Tue, 20 Jan 2009 12:52:33 +0100 From: Roman Divacky To: Konstantin Belousov Message-ID: <20090120115233.GA43828@freebsd.org> References: <200901201130.n0KBUM01043886@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200901201130.n0KBUM01043886@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r187468 - head/sys/ufs/ffs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2009 11:53:05 -0000 On Tue, Jan 20, 2009 at 11:30:22AM +0000, Konstantin Belousov wrote: > Author: kib > Date: Tue Jan 20 11:30:22 2009 > New Revision: 187468 > URL: http://svn.freebsd.org/changeset/base/187468 > > Log: > When extending inode size, we call vnode_pager_setsize(), to have a > address space where to put vnode pages, and then call UFS_BALLOC(), > to actually allocate new block and map it. When UFS_BALLOC() returns > error, sometimes we forget to revert the vm object size increase, > allowing for the pages that are not backed by the logical disk blocks. > > Revert vnode_pager_setsize() back when UFS_BALLOC() failed, for > ffs_truncate() and ffs_write(). can you describe in what scenario this can trigger? can it be that many smallish (a few tens of kB?) of mmaped files being read/write may cause this? thnx