Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 06 Dec 2012 15:15:47 +0100
From:      =?UTF-8?B?UmVuw6kgTGFkYW4=?= <rene@freebsd.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r308378 - head/science/kst
Message-ID:  <50C0A893.2020604@freebsd.org>
In-Reply-To: <20121206140607.GA40049@FreeBSD.org>
References:  <201212061028.qB6ASSZH019689@svn.freebsd.org> <20121206140607.GA40049@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 06-12-2012 15:06, Alexey Dokuchaev wrote:
> On Thu, Dec 06, 2012 at 10:28:28AM +0000, Rene Ladan wrote:
>> New Revision: 308378
>> URL: http://svnweb.freebsd.org/changeset/ports/308378
>>
>> +# Created by:	Markus Brueffer <markus@FreeBSD.org>
> 
> Please use space, not tab here.
> 
OK, fixed.

>> +OPTIONS_DEFINE=	NETCDF CDF KDEBASE
>> +CDF_DESC=	CDF data support
>> +KDEBASE=	JavaScript console
> 
> Shouldn't it read KDEBASE_DESC?  Also I fail to see how KDEBASE describes
> JavaScript console.
>
Yes, my mistake.  I think it is because the KDEBASE option pulls in
libkonsolepart.so which might provide a console, but KDE people probably
know the fine details (I was just converting the port to optionsNG).

René




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50C0A893.2020604>