Date: Sat, 02 Feb 2008 23:31:14 +0200 From: Alexander Motin <mav@FreeBSD.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Louis Mamakos <louie@transsys.com>, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netgraph/netflow ng_netflow.c Message-ID: <47A4E122.8080901@FreeBSD.org> In-Reply-To: <20080202201153.GL14339@FreeBSD.org> References: <200801271501.m0RF1Hki089075@repoman.freebsd.org> <20080202201153.GL14339@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Gleb Smirnoff пишет: > you should have asked me for review before committing! This is > not a bug, this is a feature. This was quite clear from the comments, > that you removed: > > - /* if export hook disconnected stop running expire(). */ > > This is intended behavior. We must not lose information unless > user explicitly wants to lose information. In the latter case > he will connect ng_hole(4) node to the "export" hook. But we must > not lose information if user runs some script that swaps receiving > node on the "export" hook. > > Please backout this change! Expire process was not depending completely on connected hook even before this commit. For example, every TCP session closing forces some data export. So even with export hook disconnected some data still will be lost and not just lost, but it was leading to memory leak which I have fixed with other commit. So if you insist that it was a feature then sorry. Then it should be documented and fixed to work correctly. But as soon as nobody notice that memory leak, probably nobody uses this feature actively. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47A4E122.8080901>