From owner-freebsd-fs@FreeBSD.ORG Mon May 2 23:57:18 2011 Return-Path: Delivered-To: fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1DBDD1065670 for ; Mon, 2 May 2011 23:57:18 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-annu.mail.uoguelph.ca (esa-annu.mail.uoguelph.ca [131.104.91.36]) by mx1.freebsd.org (Postfix) with ESMTP id CA05F8FC1C for ; Mon, 2 May 2011 23:57:17 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApwEAHBEv02DaFvO/2dsb2JhbACEUaI2tCiQWIR/gQEEjnmOPg X-IronPort-AV: E=Sophos;i="4.64,306,1301889600"; d="scan'208";a="119370570" Received: from erie.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.206]) by esa-annu-pri.mail.uoguelph.ca with ESMTP; 02 May 2011 19:57:16 -0400 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id B78B7B3F2D; Mon, 2 May 2011 19:57:16 -0400 (EDT) Date: Mon, 2 May 2011 19:57:16 -0400 (EDT) From: Rick Macklem To: Kostik Belousov Message-ID: <2119325179.903923.1304380636687.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: <20110503020940.N2001@besplex.bde.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_903922_2059190712.1304380636685" X-Originating-IP: [172.17.91.201] X-Mailer: Zimbra 6.0.10_GA_2692 (ZimbraWebClient - IE7 (Win)/6.0.10_GA_2692) Cc: fs@FreeBSD.org Subject: Re: newnfs client and statfs X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 23:57:18 -0000 ------=_Part_903922_2059190712.1304380636685 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi, I have attached a version of the patch that I intend to commit unless it doesn't work for Kostik's test case. Kostik, could you please test this one. Yes, Bruce, I realize you won't like it, but I have put some comments in it to try and clarify why it is coded the way it is. (The arithmetic seems to work the way I would expect it to for i386, which is the only arch I have for testing.) If the "collective concensus" is to "cheat" and put the negative values in the uint64_t on the wire, then I can commit a change to handle that later. If anyone has input w.r.t. this, please post it under the Subject heading "NFS server handling of negative f_bavail?" on freebsd-fs@freebsd.org. I basically need to move onto other issues, rick ------=_Part_903922_2059190712.1304380636685 Content-Type: text/x-patch; name=statfs.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=statfs.patch LS0tIGZzL25mc2NsaWVudC9uZnNfY2xwb3J0LmMuc2F2CTIwMTEtMDQtMzAgMjA6MTY6MzkuMDAw MDAwMDAwIC0wNDAwCisrKyBmcy9uZnNjbGllbnQvbmZzX2NscG9ydC5jCTIwMTEtMDUtMDIgMTk6 MzI6MzEuMDAwMDAwMDAwIC0wNDAwCkBAIC04MzgsMjEgKzgzOCwzMyBAQCB2b2lkCiBuZnNjbF9s b2Fkc2JpbmZvKHN0cnVjdCBuZnNtb3VudCAqbm1wLCBzdHJ1Y3QgbmZzc3RhdGZzICpzZnAsIHZv aWQgKnN0YXRmcykKIHsKIAlzdHJ1Y3Qgc3RhdGZzICpzYnAgPSAoc3RydWN0IHN0YXRmcyAqKXN0 YXRmczsKLQluZnNxdWFkX3QgdHF1YWQ7CiAKIAlpZiAobm1wLT5ubV9mbGFnICYgKE5GU01OVF9O RlNWMyB8IE5GU01OVF9ORlNWNCkpIHsKIAkJc2JwLT5mX2JzaXplID0gTkZTX0ZBQkxLU0laRTsK LQkJdHF1YWQucXZhbCA9IHNmcC0+c2ZfdGJ5dGVzOwotCQlzYnAtPmZfYmxvY2tzID0gKGxvbmcp KHRxdWFkLnF2YWwgLyAoKHVfcXVhZF90KU5GU19GQUJMS1NJWkUpKTsKLQkJdHF1YWQucXZhbCA9 IHNmcC0+c2ZfZmJ5dGVzOwotCQlzYnAtPmZfYmZyZWUgPSAobG9uZykodHF1YWQucXZhbCAvICgo dV9xdWFkX3QpTkZTX0ZBQkxLU0laRSkpOwotCQl0cXVhZC5xdmFsID0gc2ZwLT5zZl9hYnl0ZXM7 Ci0JCXNicC0+Zl9iYXZhaWwgPSAobG9uZykodHF1YWQucXZhbCAvICgodV9xdWFkX3QpTkZTX0ZB QkxLU0laRSkpOwotCQl0cXVhZC5xdmFsID0gc2ZwLT5zZl90ZmlsZXM7Ci0JCXNicC0+Zl9maWxl cyA9ICh0cXVhZC5sdmFsWzBdICYgMHg3ZmZmZmZmZik7Ci0JCXRxdWFkLnF2YWwgPSBzZnAtPnNm X2ZmaWxlczsKLQkJc2JwLT5mX2ZmcmVlID0gKHRxdWFkLmx2YWxbMF0gJiAweDdmZmZmZmZmKTsK KwkJc2JwLT5mX2Jsb2NrcyA9IHNmcC0+c2ZfdGJ5dGVzIC8gTkZTX0ZBQkxLU0laRTsKKwkJc2Jw LT5mX2JmcmVlID0gc2ZwLT5zZl9mYnl0ZXMgLyBORlNfRkFCTEtTSVpFOworCQkvKgorCQkgKiBB bHRob3VnaCBzZl9hYnl0ZXMgaXMgdWludDY0X3QgYW5kIGZfYmF2YWlsIGlzIGludDY0X3QsCisJ CSAqIHRoZSB2YWx1ZSBhZnRlciBkaXZpZGluZyBieSBORlNfRkFCTEtTSVpFIGlzIHNtYWxsCisJ CSAqIGVub3VnaCB0aGF0IGl0IHdpbGwgZml0IGluIDYzYml0cywgc28gaXQgaXMgb2sgdG8KKwkJ ICogYXNzaWduIGl0IHRvIGZfYmF2YWlsIHdpdGhvdXQgZmVhciB0aGF0IGl0IHdpbGwgYmVjb21l CisJCSAqIG5lZ2F0aXZlLgorCQkgKi8KKwkJc2JwLT5mX2JhdmFpbCA9IHNmcC0+c2ZfYWJ5dGVz IC8gTkZTX0ZBQkxLU0laRTsKKwkJc2JwLT5mX2ZpbGVzID0gc2ZwLT5zZl90ZmlsZXM7CisJCS8q IFNpbmNlIGZfZmZyZWUgaXMgaW50NjRfdCwgY2xpcCBpdCB0byA2M2JpdHMuICovCisJCWlmIChz ZnAtPnNmX2ZmaWxlcyA+ICh1aW50NjRfdClJTlQ2NF9NQVgpCisJCQlzYnAtPmZfZmZyZWUgPSBJ TlQ2NF9NQVg7CisJCWVsc2UKKwkJCXNicC0+Zl9mZnJlZSA9IHNmcC0+c2ZfZmZpbGVzOwogCX0g ZWxzZSBpZiAoKG5tcC0+bm1fZmxhZyAmIE5GU01OVF9ORlNWNCkgPT0gMCkgeworCQkvKgorCQkg KiBUaGUgdHlwZSBjYXN0cyB0byAoaW50MzJfdCkgZW5zdXJlIHRoYXQgdGhpcyBjb2RlIGlzCisJ CSAqIGNvbXBhdGlibGUgd2l0aCB0aGUgb2xkIE5GUyBjbGllbnQsIGluIHRoYXQgaXQgd2lsbAor CQkgKiBzaWduIGV4dGVuZCBhIHZhbHVlIHdpdGggYml0MzEgc2V0LiBUaGlzIG1heSBvciBtYXkK KwkJICogbm90IGJlIGNvcnJlY3QgZm9yIE5GU3YyLCBidXQgc2luY2UgaXQgaXMgYSBsZWdhY3kK KwkJICogZW52aXJvbm1lbnQsIEknZCByYXRoZXIgcmV0YWluIGJhY2t3YXJkcyBjb21wYXRpYmls aXR5LgorCQkgKi8KIAkJc2JwLT5mX2JzaXplID0gKGludDMyX3Qpc2ZwLT5zZl9ic2l6ZTsKIAkJ c2JwLT5mX2Jsb2NrcyA9IChpbnQzMl90KXNmcC0+c2ZfYmxvY2tzOwogCQlzYnAtPmZfYmZyZWUg PSAoaW50MzJfdClzZnAtPnNmX2JmcmVlOwo= ------=_Part_903922_2059190712.1304380636685--