Date: Thu, 25 Aug 2011 21:06:18 +0000 (UTC) From: Vadim Goncharov <vadim_nuclight@mail.ru> To: freebsd-fs@freebsd.org Subject: Re: touch(1) not working on directories in an msdosfs(5) envirement Message-ID: <slrnj5dea9.4ck.vadim_nuclight@kernblitz.nuclight.avtf.net> References: <1092971110.92110.1313782831745.JavaMail.root@erie.cs.uoguelph.ca> <20110820145112.Y872@besplex.bde.org> <slrnj57041.30vs.vadim_nuclight@kernblitz.nuclight.avtf.net> <20110824015751.I2167@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Bruce Evans! On Wed, 24 Aug 2011 02:19:56 +1000 (EST); Bruce Evans wrote about 'Re: touch(1) not working on directories in an msdosfs(5) envirement': >>> The above is only the least serious of the bugs in msdosfs_setattr() :-(. >>> With the above fix, plain touch works as well as possible -- it cannot >>> work perfectly since setting of atimes is not always supported. But >>> touch -r and more importantly, cp -p only work as well as possible for >>> root, since they use utimes() without the null timeptr arg that allows >>> plain touch to work. A non-null timeptr arg ends up normally requiring >>> root permissions for msdosfs where it normally doesn't require extra >>> permissions for ffs, because ownership requirements for the non-null case >>> cannot be satisfied by file systems that don't really support ownerships. >>> We fudge the ownerships and use weak checks on them in most places, but >>> for utimes() we use strict checks that almost always fail: from my old >>> version: >> >> So, now the usual case of not touching directory times on change is preserved, >> but cp -r et al. sets times as expected? Sounds good, could it be committed >> please? > Yes, cp -p works but only if the user is root or the owner of the file. > Someone else will have to commit it. Umm... but why not you?.. -- WBR, Vadim Goncharov. ICQ#166852181 mailto:vadim_nuclight@mail.ru [Anti-Greenpeace][Sober FreeBSD zealot][http://nuclight.livejournal.com]
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?slrnj5dea9.4ck.vadim_nuclight>