Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 14 May 2013 21:00:02 GMT
From:      Raphael Kubo da Costa <rakuco@FreeBSD.org>
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   Re: ports/177857: [patch] Update x11/slim to 1.3.5
Message-ID:  <201305142100.r4EL02ux037115@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/177857; it has been noted by GNATS.

From: Raphael Kubo da Costa <rakuco@FreeBSD.org>
To: Kevin Zheng <kevinz5000@gmail.com>
Cc: bug-followup@FreeBSD.org,  Henry Hu <henry.hu.sh@gmail.com>
Subject: Re: ports/177857: [patch] Update x11/slim to 1.3.5
Date: Tue, 14 May 2013 23:55:20 +0300

 Kevin Zheng <kevinz5000@gmail.com> writes:
 
 > Oops, it looks like I forgot to send the latest patch to GNATS. You can
 > find it attached here now.
 
 Thanks, a few comments below.
 
 >  LICENSE=	GPLv2
 > +LICENSE_FILE=	${WRKSRC}/COPYING
 
 This shouldn't be needed. Standard licenses such as GPLv2 already have a
 copy in Templates/Licenses.
 
 >  USES=		cmake pkgconfig
 > +USE_RC_SUBR=	slim
 >  USE_XORG=	ice sm x11 xau xdmcp xext xft xmu xorg-server xrender xt
 > -USE_RC_SUBR=	slim
 >  SUB_FILES=	pkg-message
 
 Is there a reason for this change other than ordering the "USE_"
 variables alphabetically? Otherwise it just makes svn blaming more
 difficult.
 
 >  .	if ${PORT_OPTIONS:MPAM}
 > +	@${MKDIR} ${PREFIX}/etc/pam.d
 
 You shouldn't need to do this, ${PREFIX}/etc/pam.d is part of the
 standard directories defined in Templates/BSD.local.dist.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201305142100.r4EL02ux037115>