Date: Fri, 4 Aug 2006 11:19:09 +0400 From: Yar Tikhiy <yar@comp.chem.msu.su> To: pdeuskar@FreeBSD.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h Message-ID: <20060804071909.GS97316@comp.chem.msu.su> In-Reply-To: <20060804012514.GA63379@what-creek.com> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <44D29FB6.9090209@freebsd.org> <20060804012514.GA63379@what-creek.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 04, 2006 at 01:25:14AM +0000, John Birrell wrote: > On Thu, Aug 03, 2006 at 06:15:34PM -0700, Colin Percival wrote: > > Prafulla Deuskar wrote: > > > Modified files: > > > sys/dev/em if_em.c if_em.h > > > Log: > > > Revert back changes to made in rev 1.109 of if_em.c which were unnecessary. > > > This makes it easier for us to get the changes into -current and to -stable quickly. > > > > I assume you've discussed this with glebius, who made the original changes; in > > the future, please add an "Approved by:", "No objections from:", or "Discussed > > with:" line to backout commits to make this more clear. > > Also Pyun had made a fix for the bus_dmamap_unload problem we see on sun4v. This > appears to have been backed out amongst what appears to be largely a white-space > change. > > Are you prepared to do the work to solve the bus_dmamap_unload again? As a general remark, it is a very good idea to keep large style(9) sweeps separate from actual code changes even if they are tiny. Changing style(9) shouldn't alter the binary code produced, and this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). Of course, changing line numbers will affect debug info, but the latter can be strip(1)'ed. In the case under discussion, I'd compare if_em.o with its former version to make sure no code changed. -- Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060804071909.GS97316>