Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 15 Oct 2015 17:26:24 +0200
From:      Andriy Gapon <avg@FreeBSD.org>
To:        Alexander Motin <mav@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-vendor@FreeBSD.org
Subject:   Re: svn commit: r289310 - vendor-sys/illumos/dist/common/zfs vendor-sys/illumos/dist/uts/common vendor-sys/illumos/dist/uts/common/crypto vendor-sys/illumos/dist/uts/common/crypto/io vendor-sys/illumos...
Message-ID:  <561FC5A0.3040909@FreeBSD.org>
In-Reply-To: <201510141112.t9EBCmFZ022230@repo.freebsd.org>
References:  <201510141112.t9EBCmFZ022230@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 14/10/2015 13:12, Alexander Motin wrote:
> Author: mav
> Date: Wed Oct 14 11:12:47 2015
> New Revision: 289310
> URL: https://svnweb.freebsd.org/changeset/base/289310
> 
> Log:
>   4185 add new cryptographic checksums to ZFS: SHA-512, Skein, Edon-R
>   
>   Reviewed by: George Wilson <george.wilson@delphix.com>
>   Reviewed by: Prakash Surya <prakash.surya@delphix.com>
>   Reviewed by: Saso Kiselkov <saso.kiselkov@nexenta.com>
>   Reviewed by: Richard Lowe <richlowe@richlowe.net>
>   Approved by: Garrett D'Amore <garrett@damore.org>
>   Author: Matthew Ahrens <mahrens@delphix.com>
>   
>   illumos/illumos-gate@45818ee124adeaaf947698996b4f4c722afc6d1f
> 
> Added:
>   vendor/illumos/dist/common/crypto/
>   vendor/illumos/dist/common/crypto/edonr/
>   vendor/illumos/dist/common/crypto/edonr/edonr.c   (contents, props changed)
>   vendor/illumos/dist/common/crypto/edonr/edonr_byteorder.h   (contents, props changed)
>   vendor/illumos/dist/common/crypto/skein/
>   vendor/illumos/dist/common/crypto/skein/THIRDPARTYLICENSE   (contents, props changed)
>   vendor/illumos/dist/common/crypto/skein/THIRDPARTYLICENSE.descrip   (contents, props changed)
>   vendor/illumos/dist/common/crypto/skein/skein.c   (contents, props changed)
>   vendor/illumos/dist/common/crypto/skein/skein_block.c   (contents, props changed)
>   vendor/illumos/dist/common/crypto/skein/skein_impl.h   (contents, props changed)
>   vendor/illumos/dist/common/crypto/skein/skein_iv.c   (contents, props changed)
>   vendor/illumos/dist/common/crypto/skein/skein_port.h   (contents, props changed)

It seems that these are pieces of code that can be used by both the
userland and the kernel.  I think that previously we used to import such
code into illumos-sys and then integrate it into sys/cddl (e.g.
common/zfs/).  Perhaps it is worthwhile following that convention in
this case as well?

> Modified:
>   vendor/illumos/dist/lib/libzfs/common/libzfs_dataset.c
>   vendor/illumos/dist/man/man5/zpool-features.5

Also, we probably need to synchronize man/man1m/zfs.1m in our vendor
area with the latest upstream version.  Even though we do not directly
use that file, it still would be easier to make the future imports and
also to compare (and to keep in sync) our version of the manual with the
upstream version.

Thank you for doing all the heavy lifting with this change!

-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?561FC5A0.3040909>