From owner-cvs-all@FreeBSD.ORG Thu Mar 17 01:37:27 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F34B16A4CE; Thu, 17 Mar 2005 01:37:27 +0000 (GMT) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0A1BA43D4C; Thu, 17 Mar 2005 01:37:27 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87])j2H1bPA6008297; Thu, 17 Mar 2005 12:37:25 +1100 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) j2H1bLMq009947; Thu, 17 Mar 2005 12:37:22 +1100 Date: Thu, 17 Mar 2005 12:37:15 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: "David O'Brien" In-Reply-To: <20050316205829.GA3556@dragon.NUXI.org> Message-ID: <20050317121651.N72560@delplex.bde.org> References: <200503162023.j2GKNWnJ099551@repoman.freebsd.org> <20050316205829.GA3556@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Pawel Jakub Dawidek cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/conf GENERIC src/sys/amd64/conf GENERIC X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2005 01:37:27 -0000 On Wed, 16 Mar 2005, David O'Brien wrote: > On Wed, Mar 16, 2005 at 09:54:06PM +0100, Pawel Jakub Dawidek wrote: >> On Wed, Mar 16, 2005 at 08:23:31PM +0000, David E. O'Brien wrote: >> +> -device pcn # AMD Am79C97x PCI 10/100 (precedence over 'lnc') >> +> +device nve # nVidia nForce MCP on-board Ethernet Networking >> +> +device pcn # AMD Am79C97x PCI 10/100(precedence over 'lnc') >> [...] >> +> -device pcn # AMD Am79C97x PCI 10/100 (precedence over 'lnc') >> +> +device nve # nVidia nForce MCP on-board Ethernet Networking >> +> +device pcn # AMD Am79C97x PCI 10/100(precedence over 'lnc') >> >> Why you removed this space?!:) > > Make it clear nve needs mii, and shorten long comment line. > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Better remove the bogus quotes around lnc. Quoting elsewhere in this file is inconsistent and about 1/4 of it seems to be bogus. Are the comments on precedence even correct? I think precedence according to ordering in the config file hasn't worked for many years. PCI devices may (should) have precedence over ISA ones, but that is a general property and should be expressed better. I think pcn may or may not have precedence over lnc depending on resource conflicts. pcn is PCI-only while lnc is PCI/ISA/CBUS, so it is bogus for lnc to be in the ISA-only section and very unclear how pcn has precedence over the PCI part of lnc. Bruce