Date: Thu, 15 Oct 2015 18:41:03 +0300 From: Alexander Motin <mav@FreeBSD.org> To: Andriy Gapon <avg@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-vendor@FreeBSD.org Subject: Re: svn commit: r289310 - vendor-sys/illumos/dist/common/zfs vendor-sys/illumos/dist/uts/common vendor-sys/illumos/dist/uts/common/crypto vendor-sys/illumos/dist/uts/common/crypto/io vendor-sys/illumos... Message-ID: <561FC90F.4090706@FreeBSD.org> In-Reply-To: <561FC5A0.3040909@FreeBSD.org> References: <201510141112.t9EBCmFZ022230@repo.freebsd.org> <561FC5A0.3040909@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15.10.2015 18:26, Andriy Gapon wrote: > On 14/10/2015 13:12, Alexander Motin wrote: >> Author: mav >> Date: Wed Oct 14 11:12:47 2015 >> New Revision: 289310 >> URL: https://svnweb.freebsd.org/changeset/base/289310 >> >> Log: >> 4185 add new cryptographic checksums to ZFS: SHA-512, Skein, Edon-R >> >> Reviewed by: George Wilson <george.wilson@delphix.com> >> Reviewed by: Prakash Surya <prakash.surya@delphix.com> >> Reviewed by: Saso Kiselkov <saso.kiselkov@nexenta.com> >> Reviewed by: Richard Lowe <richlowe@richlowe.net> >> Approved by: Garrett D'Amore <garrett@damore.org> >> Author: Matthew Ahrens <mahrens@delphix.com> >> >> illumos/illumos-gate@45818ee124adeaaf947698996b4f4c722afc6d1f >> >> Added: >> vendor/illumos/dist/common/crypto/ >> vendor/illumos/dist/common/crypto/edonr/ >> vendor/illumos/dist/common/crypto/edonr/edonr.c (contents, props changed) >> vendor/illumos/dist/common/crypto/edonr/edonr_byteorder.h (contents, props changed) >> vendor/illumos/dist/common/crypto/skein/ >> vendor/illumos/dist/common/crypto/skein/THIRDPARTYLICENSE (contents, props changed) >> vendor/illumos/dist/common/crypto/skein/THIRDPARTYLICENSE.descrip (contents, props changed) >> vendor/illumos/dist/common/crypto/skein/skein.c (contents, props changed) >> vendor/illumos/dist/common/crypto/skein/skein_block.c (contents, props changed) >> vendor/illumos/dist/common/crypto/skein/skein_impl.h (contents, props changed) >> vendor/illumos/dist/common/crypto/skein/skein_iv.c (contents, props changed) >> vendor/illumos/dist/common/crypto/skein/skein_port.h (contents, props changed) > > It seems that these are pieces of code that can be used by both the > userland and the kernel. I think that previously we used to import such > code into illumos-sys and then integrate it into sys/cddl (e.g. > common/zfs/). Perhaps it is worthwhile following that convention in > this case as well? I haven't decided what to do with this specific case. As I understand, now we are using FreeBSD's native crypto code instead of illumos' one. I was thinking about importing this commit only in infrastructural parts, until respective algorithms are implemented in our native crypto. I think it should not be a problem for Skein, since according to comments it is in public domain. About Edon-R I am not sure, since it seems to be CDDL. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?561FC90F.4090706>