From owner-freebsd-ports-bugs@freebsd.org Sat Jul 29 13:20:20 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F29B2DC414C for ; Sat, 29 Jul 2017 13:20:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DF0A36C0F1 for ; Sat, 29 Jul 2017 13:20:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v6TDKK0S076328 for ; Sat, 29 Jul 2017 13:20:20 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 219687] [NEW PORT] net/google-compute-engine: User daemon for Google Compute Engine Date: Sat, 29 Jul 2017 13:20:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, needs-patch, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: sunpoet@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Jul 2017 13:20:21 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D219687 --- Comment #31 from Po-Chuan Hsieh --- (In reply to Helen Koike from comment #28) 1. Either remove PKGNAMEPREFIX=3D${PYTHON_PKGNAMEPREFIX} or change this por= t as net/py-google-compute-engine. We add py- to the directory name and pyXX- to package name for Python libraries/modules. Please consider if this port is more of a library or an application. 2. We have ntpdate in base system (/usr/sbin/ntpdate). Is there any reason = to use the one from ports? 3. There is compilation error with Python 3. Please add a patch for it. byte-compiling /usr/ports/works/usr/ports/net/google-compute-engine/work/stage/usr/local/l= ib/python3.6/site-packages/google_compute_engine/network_utils.py to network_utils.cpython-36.pyc File "/usr/local/lib/python3.6/site-packages/google_compute_engine/network_utils= .py", line 47 except Exception, e: ^ SyntaxError: invalid syntax 4. Please sort RUN_DEPENDS and USE_PYTHON. 5. Use REINPLACE_ARGS=3D-i '' to avoid saving backup files. "@${REINPLACE_CMD} -i -e" in post-patch: will save backup files with "-e" suffix. % ls -l google_compute_engine/network_setup/network_setup.py* -rwxr-xr-x 1 sunpoet wheel 6454 Jul 29 20:52 google_compute_engine/network_setup/network_setup.py -rwxr-xr-x 1 sunpoet wheel 6454 Jul 19 00:49 google_compute_engine/network_setup/network_setup.py-e It should be "REINPLACE_ARGS=3D-i ''" to avoid saving backup files. % grep REINPLACE_ARGS /usr/ports/Mk/bsd.port.mk REINPLACE_ARGS?=3D -i.bak REINPLACE_CMD?=3D ${SED} ${REINPLACE_ARGS} Thanks. --=20 You are receiving this mail because: You are the assignee for the bug.=