Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 02 Feb 2003 00:36:45 +0000
From:      Mark Murray <mark@grondar.org>
To:        Matthew Dillon <dillon@apollo.backplane.com>
Cc:        current@FreeBSD.ORG
Subject:   Re: Style fixups for proc.h 
Message-ID:  <200302020036.h120ajaX040534@grimreaper.grondar.org>
In-Reply-To: Your message of "Sat, 01 Feb 2003 16:14:28 PST." <200302020014.h120ESxb018045@apollo.backplane.com> 

next in thread | previous in thread | raw e-mail | index | archive | help
Matthew Dillon writes:
> 
> :WARNS=5.
> 
>     This isn't helpful.  I tried adding every -W switch in bsd.sys.mk
>     and couldn't reproduce the problem.  What compiler option is causing
>     the problem?

I don't know which specific one.

>    Ok, now I'm really confused.  How can it not always help?  If the 
>    arguments are the same as the arguments declared in the underlying
>    procedures why would an error still be produced?  The diff you produced
>    for proc.h is *already* fairly extensive.  If you want to fix this, 
>    you only need to fix the lines generating compiler warnings.

"arg" in a function prototype gets confused with variable "arg" in
some function(s).

>    I really dislike screwing around with source code to work around
>    bugs in the the compiler, or lint.  Given the choice of underlines
>    or leaving the arguments unnamed, I would leave them unnamed.  Or I
>    would figure out and remove whatever broken compiler option is generating
>    the warning in the first place.

Then can we just get the proc.h prototypes into a (any) consistent
style?

M
--
Mark Murray
iumop ap!sdn w,I idlaH

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200302020036.h120ajaX040534>