From owner-cvs-all Fri Nov 15 12:24:42 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB23037B401; Fri, 15 Nov 2002 12:24:40 -0800 (PST) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 81F3743E4A; Fri, 15 Nov 2002 12:24:39 -0800 (PST) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (IDENT:brdavis@localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.12.3/8.12.3) with ESMTP id gAFKOVs7011293; Fri, 15 Nov 2002 12:24:31 -0800 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.12.3/8.12.3/Submit) id gAFKOVGt011292; Fri, 15 Nov 2002 12:24:31 -0800 Date: Fri, 15 Nov 2002 12:24:31 -0800 From: Brooks Davis To: Andrew Gallatin Cc: Brooks Davis , Sam Leffler , cvs-all@FreeBSD.org Subject: Re: if_xname ( was Re: cvs commit: src/sys/dev/an if_an.c if_an_isa.c if_an_pccard.c if_an_pci.c src/sys/dev/ar if_ar.c src/sys/dev/awi awi.c if_awi_pccard.c src/sys/dev/bge if_bge.c if_bgereg.h src/sys/dev/cm smc90cx6.c src/sys/dev/cnw if_cnw.c src/sys/dev/cs ...) Message-ID: <20021115122431.E4826@Odin.AC.HMC.Edu> References: <200211142354.gAENstXE004776@repoman.freebsd.org> <20021115143004.A54902@grasshopper.cs.duke.edu> <20021115114335.A4826@Odin.AC.HMC.Edu> <15829.20547.24539.647339@grasshopper.cs.duke.edu> <20021115120447.C4826@Odin.AC.HMC.Edu> <15829.21926.961058.610694@grasshopper.cs.duke.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="cPi+lWm09sJ+d57q" Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <15829.21926.961058.610694@grasshopper.cs.duke.edu>; from gallatin@cs.duke.edu on Fri, Nov 15, 2002 at 03:14:30PM -0500 X-Virus-Scanned: by amavisd-milter (http://amavis.org/) on odin.ac.hmc.edu Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --cPi+lWm09sJ+d57q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 15, 2002 at 03:14:30PM -0500, Andrew Gallatin wrote: >=20 > But what about ip_if*'s (ab)use of if_unit in the critical path? > Introducing extra code here to do string parsing is my only concern.=20 > If Luigi is OK with it, then I am too. Well, the string compare of if_name was already in the critical path, it now looks at an average of one more character with if_xname so I seriously doubt that will matter. The wildcard case will be slower because it becomes a fnmatch call, but Luigi was actually willing to just nuke that feature. The recent import of fnmatch() into libkern gave me an easy way to implement it much more powerfully. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --cPi+lWm09sJ+d57q Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE91Vf+XY6L6fI4GtQRAn8wAJwPgHWDbG6zxrXEZqZQpLhlOcIz3QCg3itV uIQFtN4lZu/55aLLdbzoLKo= =W7Id -----END PGP SIGNATURE----- --cPi+lWm09sJ+d57q-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message