From owner-svn-ports-all@FreeBSD.ORG Wed May 15 04:54:19 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id A2D28EDD; Wed, 15 May 2013 04:54:19 +0000 (UTC) (envelope-from makc@freebsd.org) Received: from mail.issp.ac.ru (mail.issp.ac.ru [77.236.34.3]) by mx1.freebsd.org (Postfix) with ESMTP id 2A3CA8A2; Wed, 15 May 2013 04:54:18 +0000 (UTC) Received: from host-217-197-197-20.rev.as20985.net [217.197.197.20:50900] (HELO/EHLO mercury.ph.man.ac.uk, authenticated with LOGIN) by mail.issp.ac.ru with ESMTP/inet id r4F4sIGm088838 (using TLSv1/SSLv3, with cipher DHE-RSA-AES256-SHA (256 bits), verified NO) Wed, 15 May 2013 08:54:18 +0400 (MSK) From: Max Brazhnikov To: Johan van Selst Subject: Re: svn commit: r318127 - in head/games/xboard: . files Date: Wed, 15 May 2013 04:54:16 +0000 Message-ID: <1722947.Vxd1CHFxaz@mercury.ph.man.ac.uk> User-Agent: KMail/4.10.2 (FreeBSD/9.1-STABLE; KDE/4.10.2; amd64; ; ) In-Reply-To: <20130514201011.GA50950@mud.stack.nl> References: <201305132020.r4DKKTen074755@svn.freebsd.org> <20130514201011.GA50950@mud.stack.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="ISO-8859-1" Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , Jason Helfman , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 May 2013 04:54:19 -0000 On Tue, 14 May 2013 22:10:11 +0200 Johan van Selst wrote: > Jason Helfman wrote: > > > > > - Add deinstall script to avoid leftovers > > > > Is there any particular reason this was added in favor of a plist entry? > > > Yes, plist entries are executed before PORTDATA cleanups. Since PORTDATA > > > files are installed below this directory, an @rmdir in plist would fail. > > > I certainly welcome suggestions for a cleaner solution. > > I believe adding this to the plist would take care of your needs. > > @unexec /bin/rmdir %%PREFIX%%/share/games 2>/dev/null || true > > No, it won't. Such a command will be executed too early when the package > is removed. Another alternative is to not use PORTDATA. Besides does xboard work without PORTDATA files? Btw, since the port installs MIME data files it needs 'USES= shared-mime-info'. '@dirrmtry share/mime*' should be removed from plist after that. Cheers, Max