From owner-freebsd-current@freebsd.org Mon Jan 15 17:53:00 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2AD49EBE50F; Mon, 15 Jan 2018 17:53:00 +0000 (UTC) (envelope-from tijl@freebsd.org) Received: from mailrelay111.isp.belgacom.be (mailrelay111.isp.belgacom.be [195.238.20.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "relay.skynet.be", Issuer "GlobalSign Organization Validation CA - SHA256 - G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 850801C1F; Mon, 15 Jan 2018 17:52:58 +0000 (UTC) (envelope-from tijl@freebsd.org) X-Belgacom-Dynamic: yes IronPort-PHdr: =?us-ascii?q?9a23=3AfezAvhMMq/S4828L+84l6mtUPXoX/o7sNwtQ0KIM?= =?us-ascii?q?zox0K/z8p8bcNUDSrc9gkEXOFd2Cra4c0qyO6+jJYi8p2d65qncMcZhBBVcuqP?= =?us-ascii?q?49uEgeOvODElDxN/XwbiY3T4xoXV5h+GynYwAOQJ6tL1LdrWev4jEMBx7xKRR6?= =?us-ascii?q?JvjvGo7Vks+7y/2+94fcbglUmTaxe69+IAmrpgjNq8cahpdvJLwswRXTuHtIfO?= =?us-ascii?q?pWxWJsJV2Nmhv3+9m98p1+/SlOovwt78FPX7n0cKQ+VrxYES8pM3sp683xtBnM?= =?us-ascii?q?VhWA630BWWgLiBVIAgzF7BbnXpfttybxq+Rw1DWGMcDwULs5Qiqp4bt1RxD0iS?= =?us-ascii?q?cHLz85/3/Risxsl6JQvRatqwViz4LIfI2ZMfxzdb7fc9wHX2pMRshfWSxfDI2h?= =?us-ascii?q?bIUADeQBMulEoIfyvFYOsQK+CRWwCO/z1jNFhHn71rA63eQ7FgHG2RQtEcwPsH?= =?us-ascii?q?TWqNX+KbkfUeeyzKnT0zrDaulZ2THm6IPVdR0hvfCMXbB0ccfKyUcvDR3KgUuN?= =?us-ascii?q?pIL4MT2ZzOMNs3KU7+d5U++klm0pqxlprzWs28sgkJfFi40Ux1ze6Cl0zog4Kc?= =?us-ascii?q?elREN1btOpFoZbuTuAOItsWMwiRnlluCM9yrIbp5G2ZDMKyJE7xx7HbPyHbpSI?= =?us-ascii?q?7grjVOmPJTd4g2poeLGliBa28Eigz/PzVtOz0FpQsipFk9vMtnQX2xPP7ciHTe?= =?us-ascii?q?B98Vmk2TmV0QDT8ftIIUcularUM5Ihw7gwmYQPsUnbHSL6hV/6gLGZe0gl4OSk?= =?us-ascii?q?9urqb7v8qpOBOYJ5hRnyMqE0lcy+BeQ4PBIOX2+e+emkyL3j/E/5QLFRg/04iK?= =?us-ascii?q?nWro7VKt8ApqGkGQNV1Zwj6xmnAze8zNsYhWUHLE5CeB+fgYjpIU/BL+7jAvek?= =?us-ascii?q?nlugiS9rx/fcPr39GZXANXbDkK3/crlj8EFc0xc8wcpY55JOBbELOOjzVVPptN?= =?us-ascii?q?zEEh85NBS5w+j9CNpjyIwRQnmPDbKAPKzOrF+I/PgvLPeKZI8Jozv9JeIl6ODw?= =?us-ascii?q?gnAigl8SYLOl3ZwNaHC3Bv5mOVmWYWLwgtcdFmcHphI+TO3riVyDSzFTYneyX6?= =?us-ascii?q?0n6zE1EoKpE5nMSZu2gLOcxiu7GYdWZm9eAFCWDXjob5mEW+sLaC+KPMBhlyYL?= =?us-ascii?q?VaO9S4A/zhyuuhX6xKR5IeXP4S0XqIjv1N9v5+3cjRsy7yB7D9yB02GRSGF5hm?= =?us-ascii?q?EISCQo06B+vUN9ykyO0aZig/NGC9Nc/OhJXRogOZ7b1ex6BMj4WhjdcdeRVFam?= =?us-ascii?q?XtKmDCktTtIx3dAOeVxyG8u8gRDFxCeqDaUVmKKVC5Mv6aLTwmL9J8Fny3bJh+?= =?us-ascii?q?EdiAwKS9VOOSWNhq9k8QHXA8adj0WUja+0eKI08jTA+U244SyJpk4OAyBqVqCQ?= =?us-ascii?q?YXEdYgP9qtPi60bLSaTmXagmMA9p59SPJ4FxRpvul1oQF6SrA8jXf2/kwzT4Ph?= =?us-ascii?q?2P3L7ZKdOyI2g=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2DHBABL6Vxa/4aF9lFdGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYNBVhB0FBOEE4sYjWoBAYIBMgGZDymFHAKEUEQUAQEBAQEBAQE?= =?us-ascii?q?BAWoogjgkAYJHAQUjMyMQCw4KAgIFIQICDyoeBhOKN6l+gieJSQEBAQEBBQEBA?= =?us-ascii?q?QEBI4EPjDCDLwSBb4MXgmUFo2SIDI0ygQCTHZhhNiKBUEwwCIJnCYRPQDeNDAE?= =?us-ascii?q?BAQ?= X-IPAS-Result: =?us-ascii?q?A2DHBABL6Vxa/4aF9lFdGQEBAQEBAQEBAQEBAQcBAQEBAYN?= =?us-ascii?q?BVhB0FBOEE4sYjWoBAYIBMgGZDymFHAKEUEQUAQEBAQEBAQEBAWoogjgkAYJHA?= =?us-ascii?q?QUjMyMQCw4KAgIFIQICDyoeBhOKN6l+gieJSQEBAQEBBQEBAQEBI4EPjDCDLwS?= =?us-ascii?q?Bb4MXgmUFo2SIDI0ygQCTHZhhNiKBUEwwCIJnCYRPQDeNDAEBAQ?= Received: from 134.133-246-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.246.133.134]) by relay.skynet.be with ESMTP; 15 Jan 2018 18:51:43 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.15.2/8.15.2) with ESMTP id w0FHphCG079998; Mon, 15 Jan 2018 18:51:43 +0100 (CET) (envelope-from tijl@FreeBSD.org) Date: Mon, 15 Jan 2018 18:51:43 +0100 From: Tijl Coosemans To: David Chisnall Cc: Jan Beich , Ed Maste , Luca Pizzamiglio , FreeBSD Current , freebsd-ports@freebsd.org Subject: Re: atomic in i386 Current after CLANG 6 upgrade Message-ID: <20180115185143.0ef2f67b@kalimero.tijl.coosemans.org> In-Reply-To: <03DDFE7A-B5FE-4DE5-98D8-AF28EFDDFACF@FreeBSD.org> References: <20180115125756.37b803ba@kalimero.tijl.coosemans.org> <03DDFE7A-B5FE-4DE5-98D8-AF28EFDDFACF@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 17:53:00 -0000 On Mon, 15 Jan 2018 17:08:58 +0000 David Chisnall wr= ote: > On 15 Jan 2018, at 17:00, Jan Beich wrote: >> It wouldn't help (see below). Clang 6 accidentally made __atomic* work >> enough to satisfy configure check but not for the port to build. I guess, >> it also confuses configure in net/librdkafka and net-mgmt/netdata. >=20 > Can we (by which I probably mean emaste@) push out an EN that adds the > atomic.c from compiler-rt to our libgcc_s? That should provide all of > these helper functions. Clang assumes that they exist because both > compiler-rt and vaguely recent libgcc_s provide them. Recent GCC will > also assume that they exist and so the correct fix is probably for us > to make them to exist. >=20 > If this is difficult, then we can perhaps provide a port that compiles > atomic.c into libatomic_fudge.so or similar and provides a libgcc_s.so > that=E2=80=99s a linker script that forces linking to libatomic_fudge.so = and > libgcc_s.so. I can understand emitting function calls on i486 but according to Jan, clang is emitting function calls on i586 as well. It used to inline this which is why we never needed these functions in libgcc. Is it normal that clang emits function calls now?