Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 27 Jan 2019 12:45:12 +0000
From:      =?UTF-8?Q?Vin=C3=ADcius_Zavam?= <egypcio@freebsd.org>
To:        Mathieu Arnold <mat@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org,  svn-ports-head@freebsd.org
Subject:   Re: svn commit: r490457 - in head: . www www/wml www/wml/files
Message-ID:  <CA%2BKr6DOkUDCF=9z8N-Y26KKt3AS=5dU8iN_ygpE_yTSonus41g@mail.gmail.com>
In-Reply-To: <20190122154805.6os5tzlq2a7hhsnt@ogg.in.absolight.net>
References:  <201901160856.x0G8ub20095516@repo.freebsd.org> <20190116092121.os4tzf2gejvv5pjv@atuin.in.mat.cc> <CA%2BKr6DPoHujkU8VQ9CCpUB23r147Qx1zuYDV_eCam4q9h30PNg@mail.gmail.com> <CAP7rwchcrYJByWh6UPQciBvKMwE4=m7LQJDbsAJ%2B7iROkuE0nQ@mail.gmail.com> <20190122154805.6os5tzlq2a7hhsnt@ogg.in.absolight.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Am Di., 22. Jan. 2019 um 15:48 Uhr schrieb Mathieu Arnold <mat@freebsd.org>=
:

> On Thu, Jan 17, 2019 at 01:34:38PM -0700, Adam Weinberger wrote:
> > On Thu, Jan 17, 2019 at 12:59 PM Vin=C3=ADcius Zavam <egypcio@freebsd.o=
rg>
> wrote:
> > >
> > >
> > >
> > > Am Mi., 16. Jan. 2019 um 09:21 Uhr schrieb Mathieu Arnold <
> mat@freebsd.org>:
> > >>
> > >> On Wed, Jan 16, 2019 at 08:56:37AM +0000, Vin=C3=ADcius Zavam wrote:
> > >> > Author: egypcio
> > >> > Date: Wed Jan 16 08:56:37 2019
> > >> > New Revision: 490457
> > >> > URL: https://svnweb.freebsd.org/changeset/ports/490457
> > >> >
> > >> > Log:
> > >> >   [REVIVE PORT] www/wml: The WML, 2.0.12
> > >> >
> > >> >     Some websites are still using WML, https://torproject.org is
> one of them.
> > >> >
> > >> >     svn copy made against head/www/wml r437070
> > >>
> > >> Mmmm, saying it does not make it so, the commit has not registered t=
he
> > >> copy.  Could you please do it again but with actually doing the svn
> cp.
> > >>
> > >> --
> > >> Mathieu Arnold
> > >
> > >
> > > hi mat@, how are you doing?
> > >
> > > the initial work to revive this port was started with a repo copy,
> based on head/www/wml@437070. the diff for www/wml needed to be reworked
> some times, and turned to be just a 'regular' patch file uploaded to
> phabricator - version was kept the same, revision was bumped.
> > >
> > > what do you mean by 'not registered copy' ? now the approved version
> of it is already in ports/head and the diferential was closed.
> >
> > The commit itself needs to be copied from the deleted version. Have a
> > read through
> https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/por=
ts.html#ports-qa-re-adding
> > and once you're ready, speak up if you want a hand with it.
>
> Ping.
>
> --
> Mathieu Arnold
>

hey, hello everyone. many thanks for the extra input! very appreciated.

right now I can not stop high-prio things here and work this change as fast
as you might like me to, so it will be 'on hold' on my TODO list - and I
really would love to do it right, without any damages to the tree or
whatever it relates to (yes, I will maybe need an extra hand though).

in a side note, I would also like to share that if one goes to "19. Ports
Specific FAQ" and search for 'revive' there will pop no results at all. I
did miss this section's details during the time I was working to
reintegrate this port back to our tree. you all can check the Differential
reviews on phabricator, and all the history we produced there. sadly the
"ports-qa-re-adding" just popped out here, after my commit [maybe because I
mentioned the 'svn copy' on the log msg] - we spend more time and efforts
worried about variables orders rather than the steps related to revive a
port (since feb. 2018).

please, do not get me wrong! I am thankful for all the inputs and the extra
care you all are showing here to maintain the tree in shape and also
thankful to learn more with your inputs about this particular commit. thank
you Araujo, Rene, Beat, Danilo, Adam and Mathieu!

KR,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2BKr6DOkUDCF=9z8N-Y26KKt3AS=5dU8iN_ygpE_yTSonus41g>