Date: Thu, 3 Mar 2016 13:58:23 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Hans Petter Selasky <hps@selasky.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r296320 - in head/sys: kern sys Message-ID: <20160303115823.GQ67250@kib.kiev.ua> In-Reply-To: <56D821A7.2020105@selasky.org> References: <201603021846.u22IkHWM010861@repo.freebsd.org> <56D81918.6020403@selasky.org> <20160303112716.GO67250@kib.kiev.ua> <56D821A7.2020105@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 03, 2016 at 12:36:07PM +0100, Hans Petter Selasky wrote: > On 03/03/16 12:27, Konstantin Belousov wrote: > >> >BTW: The FreeBSD kernel version should have been bumped because > >> >_callout_stop_safe() is a public callout API, used by all external > >> >kernel modules, which now will have undefined behaviour until recompiled. > > The change was done in a way which is compatible with the pre-commit > > callout_stop_safe(9) users. I even consider it mergeable into the > > stable/10 without requiring any shims. > > > > > > Yes, your change is compatible if you compile the code, but not binary > compatible. See the following macros, and how they use _callout_stop_safe(): My change is binary compatible. > > #define callout_stop(c) _callout_stop_safe(c, 0, NULL) > #define callout_async_drain(c, d) \ > _callout_stop_safe(c, 0, d) > > Because callout_stop(c) is a macro, you've now change the API for > callout_stop() aswell. This is what I think will break binary > compatibility in 10.x. How my commit changes anything for either callout_stop(), or for callout_async_drain(), or for callout_drain() ? > > That's why the need to bump __FreeBSD_version__ > > --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160303115823.GQ67250>