From owner-freebsd-current@FreeBSD.ORG  Wed Aug 25 17:49:14 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E4FD716A4CF; Wed, 25 Aug 2004 17:49:14 +0000 (GMT)
Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id F143043D3F; Wed, 25 Aug 2004 17:49:13 +0000 (GMT)
	(envelope-from ru@ip.net.ua)
Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213])
	by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i7PHn9JH003576
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Wed, 25 Aug 2004 20:49:10 +0300 (EEST)
	(envelope-from ru@ip.net.ua)
Received: (from ru@localhost)
	by heffalump.ip.net.ua (8.13.1/8.13.1) id i7PHnDZd097567;
	Wed, 25 Aug 2004 20:49:13 +0300 (EEST)
	(envelope-from ru)
Date: Wed, 25 Aug 2004 20:49:09 +0300
From: Ruslan Ermilov <ru@FreeBSD.org>
To: "David O'Brien" <obrien@FreeBSD.org>, current@FreeBSD.org
Message-ID: <20040825174908.GA97530@ip.net.ua>
References: <1093402508.488.8.camel@home>
	<20040825134842.M553@beagle.kn.op.dlr.de> <20040825134722.GD5872@ip.net.ua>
	<20040825173707.GH53710@dragon.nuxi.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="envbJBWh7q8WU6mo"
Content-Disposition: inline
In-Reply-To: <20040825173707.GH53710@dragon.nuxi.com>
User-Agent: Mutt/1.5.6i
X-Virus-Scanned: by amavisd-new
Subject: Re: BETA1 5.3 make world DESTDIR failure
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Aug 2004 17:49:15 -0000


--envbJBWh7q8WU6mo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 25, 2004 at 10:37:07AM -0700, David O'Brien wrote:
> On Wed, Aug 25, 2004 at 04:47:22PM +0300, Ruslan Ermilov wrote:
> > as IMAKEENV (from Makefile.inc1) doesn't utilize DESTDIR.  I think I
> > know how to fix "make world DESTDIR=3D/foo" to make it work again -- we
> > need to convert all DESTDIR uses in Makefile.inc1 to be command-line
> > variables.  I'm currently testing this patch, and it looks promising:
>=20
> Please also test 'make world' without DESTDIR in /etc/make.conf, but with
> 1. "HISTORICAL_MAKE_WORLD=3Dyes" in /etc/make.conf
> 2. env HISTORICAL_MAKE_WORLD=3Dyes make world
> before committing.
>=20
That's pointless for this change.  If HISTORICAL_MAKE_WORLD is defined
and DESTDIR is not (irrelevant where), "make world" is just equivalent
to "make buildworld" followed by "make installworld".  Clearly, "make
buildworld" without DESTDIR works with and without this change.


Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer

--envbJBWh7q8WU6mo
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (FreeBSD)

iD8DBQFBLNEUqRfpzJluFF4RAq4+AJ4lSwE6gqtruUiVrBtbf/AaZXkQFACfUrna
xI2xioTAtAPIqgFNBEMZT8E=
=lQXW
-----END PGP SIGNATURE-----

--envbJBWh7q8WU6mo--