Date: Sun, 29 Jul 2001 10:05:35 +0930 From: Greg Lehey <grog@FreeBSD.org> To: David O'Brien <obrien@FreeBSD.org> Cc: Kris Kennaway <kris@obsecurity.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Committer relations (was: cvs commit: src/usr.sbin/pkg_install/add main.c src/usr.sbin/pkg_install/lib str.c) Message-ID: <20010729100535.B68202@wantadilla.lemis.com> In-Reply-To: <20010728110330.B11239@dragon.nuxi.com>; from obrien@FreeBSD.org on Sat, Jul 28, 2001 at 11:03:30AM -0700 References: <200107280444.f6S4iAu46223@freefall.freebsd.org> <20010727222750.A60313@xor.obsecurity.org> <20010728110330.B11239@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday, 28 July 2001 at 11:03:30 -0700, David O'Brien wrote: > On Fri, Jul 27, 2001 at 10:27:51PM -0700, Kris Kennaway wrote: >> >> I wasn't wearing my security officer hat in requesting the backout, I >> was wearing my "Joe Ordinary Committer" hat who had his face slapped > > How was I slapping your face? David, you say that you changed Kris' code and had it reviewed by several people. Why was Kris not one of those people? > I saw code that could be improved a little. So I did. But you didn't tell Kris about it. One of the things about working in a development team is that people should learn from each other. You obviously have something to contribute, and there were good technical reasons for what you did. The way you did it was much less good: I can certainly consider that a slap in the face. Your comments during this discussion bear out this attitude. >> Just to be clear, we have committer guidelines which support this >> request. > > So every time I see code (w/o a clear maintainer) that could be done a > little bit better, I need to make a diff, post it, have a bikeshed > discussion about it, get the permission of the one that wrote that code > originally. Well, that's a case-by-case basis. In some cases, this would be the correct approach. > Christ, you do want to make this project so bureaucratic it is mired > in molasses. I see no evidence of that. > Sorry I am not going to put 3 hours of work into a 4k diff. That's your choice. But whichever way you go, please try to be more civil towards your fellow committers. Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010729100535.B68202>